Bug 118364 - [PATCH] port mail/qmail-scanner: new option to use C wrapper (no suid perl)
Summary: [PATCH] port mail/qmail-scanner: new option to use C wrapper (no suid perl)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-01 00:00 UTC by Rainer Schwarze
Modified: 2008-02-21 12:50 UTC (History)
0 users

See Also:


Attachments
file.diff (3.99 KB, patch)
2007-12-01 00:00 UTC, Rainer Schwarze
no flags Details | Diff
qmail-scanner.txt (5.40 KB, text/plain)
2008-02-14 14:52 UTC, Felippe de Meirelles Motta
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Schwarze 2007-12-01 00:00:01 UTC
Using the port mail/qmail-scanner requires using suid perl or a C wrapper which simply calls the perl script. Using the C wrapper was not supported by the ports Makefile.

The attached patch adds an option CWRAPPER to the Makefile - turned on by default - which installs the C wrapper being located in the contrib directory of the qmail-scanner package. The patch also adjusts files/pkg-install.in and files/pkg-message.in .

The diff was created against the standard qmail-scanner revision, but with this patch applied:
http://www.freebsd.org/cgi/query-pr.cgi?prp=118139-2-diff
(PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/118139 )

(I'm new to FreeBSD / ports, so I'm not really sure, that I adjusted all relevant parts of the Makefile (CONTRIB?) and the other files.)

Fix: see patch file

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-12-01 00:00:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

itetcu@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2007-12-01 00:00:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2008-01-24 08:14:58 UTC
Responsible Changed
From-To: itetcu->freebsd-ports-bugs

With bugmeister hat on, reset itetcu's ownership of this one, since he has 
been inactive for some time. 

It also looks like this one is eligible for maintainer-timeout.
Comment 4 Renato Botelho freebsd_committer freebsd_triage 2008-01-24 11:45:03 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

I'll take it due to itetcu inactivity. Approved by portmgr.
Comment 5 Felippe de Meirelles Motta 2008-02-14 14:52:45 UTC
Hi all,

I make minor changes in this patch, as add CWRAPPER script in pkg-plist. 
I'ave tested with port test (part of porttools), because i don't have an 
tinderbox now.

Thanks! :)
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-02-21 12:47:31 UTC
garga       2008-02-21 12:47:28 UTC

  FreeBSD ports repository

  Modified files:
    mail/qmail-scanner   Makefile pkg-plist 
    mail/qmail-scanner/files pkg-install.in pkg-message.in 
  Log:
  - Add a new OPTION CWRAPPER, on by default. Using this option qmail-scanner
    doesn't need suidperl anymore
  - Bump PORTREVISION
  
  PR:             ports/118364
  Submitted by:   Rainer Schwarze <rsc@admadic.de>
  Reworked by:    maintainer
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.22      +29 -3     ports/mail/qmail-scanner/Makefile
  1.4       +8 -2      ports/mail/qmail-scanner/files/pkg-install.in
  1.4       +6 -8      ports/mail/qmail-scanner/files/pkg-message.in
  1.9       +1 -0      ports/mail/qmail-scanner/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Renato Botelho freebsd_committer freebsd_triage 2008-02-21 12:47:55 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!