Main changes: - The periodic script should print a banner, like all other periodic script - Don't sort the PD heading output, it breaks with certain numbering Minor nits: - Fix spelling - pet portlint(1) - Use awk(1) to alleviate the need for additional wc(1) - remove non-portable -z flag to cmp(1) (yes, I'm using this script on RedHat Linux, it eases my pain :) Feel free to incorporate only the changes you see fit, the sorting and periodic banner should stay, however. Port maintainer (ruben@verweg.com) is cc'd. Generated with FreeBSD Port Tools 0.77 How-To-Repeat: When the enclosure numbering starts from zero, the sorting will shuffle the heading line around, observe: # printf "ENC\n0\n1\n"|sort -n -k 1 0 ENC 1 So the heading must be printed before the pipeline to awk|sort.
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->bsam Take.
bsam 2007-12-27 00:15:49 UTC FreeBSD ports repository Modified files: sysutils/linux-megacli Makefile sysutils/linux-megacli/files 407.status-mfi-raid.in README-status-mfi-raid.txt megacli.sh.in Log: Main changes: - The periodic script should print a banner, like all other periodic script - Don't sort the PD heading output, it breaks with certain numbering Minor nits: - Fix spelling - pet portlint(1) - Use awk(1) to alleviate the need for additional wc(1) - remove non-portable -z flag to cmp(1) PR: 118416 Submitted by: Ulrich Spoerlein <uspoerlein at gmail.com> Reviewed by: maintainer timeout (3 weeks) Revision Changes Path 1.5 +2 -3 ports/sysutils/linux-megacli/Makefile 1.2 +5 -3 ports/sysutils/linux-megacli/files/407.status-mfi-raid.in 1.2 +2 -2 ports/sysutils/linux-megacli/files/README-status-mfi-raid.txt 1.3 +2 -2 ports/sysutils/linux-megacli/files/megacli.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks! (I just s/printf/echo at the shell command)