Bug 119012 - [PATCH] x11-servers/xorg-server: incorrect SUID option handling
Summary: [PATCH] x11-servers/xorg-server: incorrect SUID option handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-25 15:00 UTC by Dmitry Marakasov
Modified: 2008-01-02 12:59 UTC (History)
0 users

See Also:

Attachments
xorg-server.patch (1.15 KB, patch)
2007-12-25 15:00 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2007-12-25 15:00:03 UTC 
When user has no NO_SUID_XSERVER=yes line in make.conf and turns off SUID option in xorg-server port, it will still be installed suid. The patch corrects this behavior.

Before patch:

SUID option in port | NO_SUID_XSERVER | result
--------------------+-----------------+-------
on                  | undefined       | suid
on                  | = YES           | suid
on                  | = NO            | suid
off                 | undefined       | suid
off                 | = YES           | nosuid
off                 | = NO            | suid

After patch:

SUID option in port | NO_SUID_XSERVER | result
--------------------+-----------------+-------
on                  | undefined       | suid
on                  | = YES           | nosuid
on                  | = NO            | suid
off                 | undefined       | nosuid
off                 | = YES           | nosuid
off                 | = NO            | nosuid

Also it may be good to update the message displayed when x server is installed suid
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-12-25 21:16:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Florent Thoumie freebsd_committer freebsd_triage 2008-01-02 12:59:03 UTC 
State Changed
From-To: open->closed

Committed. Thanks!