The japanese/rogue_s port still uses sgtty, while there is some termio code in there that we can easily hack to termios. This makes rogue_s work with kernels that don't have COMPAT_43TTY. Fix: Apply the following patch:
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thank you for submitting a patch. I tried it, but in some cases the player character('@') wrongly remains on the screen, and in case of playing on the 'screen', sometimes game messages were printed at the wrong position (next to '@' character). Do you have any ideas or do you know some references or related patches which I should looked in? Thanks,
* Yoshihiko Sarumaru <mistral@imasy.or.jp> wrote: > Thank you for submitting a patch. > I tried it, but in some cases the player character('@') > wrongly remains on the screen, and in case of playing > on the 'screen', sometimes game messages were printed > at the wrong position (next to '@' character). > > Do you have any ideas or do you know some references > or related patches which I should looked in? Now that I'm looking through the patch, I already see some stuff that's actually quite bitrotten in the source code itself, like hardcoded variables around lines 910 in machdep.c. Did you experience those problems when you didn't use my patch? -- Ed Schouten <ed@fxq.nl> WWW: http://g-rave.nl/
Replying to myself: For some reason, rogue_s includes its own Curses implementation that is even older than the FreeBSD project itself. I'll investigate this problem further, but there's also a great chance that this is not caused by this patch, but by the curses implementation, because it looks like it's caused by faulty escape sequences. -- Ed Schouten <ed@fxq.nl> WWW: http://g-rave.nl/
It almost works fine! But with my environment, Ctrl-Y sends suspend signal to rogue_s and rogue_s goes to suspended state. Following minor change works for me. -++ _tty.c_cc[VSUSP] = 0; +++ _tty.c_cc[VSUSP] = _tty.c_cc[VDSUSP] = 0; This may correspond to the previous code: > ltc_temp.t_suspc = ltc_temp.t_dsuspc = -1; I will approve to apply your patch to rogue_s port, if you think above my change is appropriate. Thanks, Ed Schouten wrote: > Hello, > > Could you please try the attached diff? It no longer shows the artifacts > on my machine. It removes the hardcoded VTIME/VMIN indices and partially > reverts some of the work, which makes the terminal flushing work again. > > Yours, >
* Yoshihiko Sarumaru <mistral@imasy.or.jp> wrote: > I will approve to apply your patch to rogue_s port, if you think > above my change is appropriate. Just walked through my list of PR's and saw I forgot to approve your patch. Please commit this patch. :-) -- Ed Schouten <ed@fxq.nl> WWW: http://g-rave.nl/
nork 2008-02-04 17:03:48 UTC FreeBSD ports repository Modified files: japanese/rogue_s Makefile japanese/rogue_s/files patch-aa patch-ac Log: Fix build error without sgtty.h, and investigate some terminal codes. PR: ports/119113 Submitted by: Ed Schouten ed at fxq.nl Yoshihiko Sarumaru mistral at imasy.or.jp (maintainer) Approved by: Yoshihiko Sarumaru mistral at imasy.or.jp (maintainer) Revision Changes Path 1.5 +1 -0 ports/japanese/rogue_s/Makefile 1.2 +1 -1 ports/japanese/rogue_s/files/patch-aa 1.2 +92 -1 ports/japanese/rogue_s/files/patch-ac _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks!