Bug 119588 - [PATCH] x11-toolkits/qt33: fix make deinstall
Summary: [PATCH] x11-toolkits/qt33: fix make deinstall
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-12 08:10 UTC by Sunpoet Po-Chuan Hsieh
Modified: 2008-01-21 18:20 UTC (History)
0 users

See Also:


Attachments
file.diff (354 bytes, patch)
2008-01-12 08:10 UTC, Sunpoet Po-Chuan Hsieh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sunpoet Po-Chuan Hsieh 2008-01-12 08:10:01 UTC
/usr/local/share/qt/mkspecs is used by devel/qmake, dependency of x11-toolkits/qt33.
Thus, deinstallation of x11-toolkits/qt33 shall not remove /usr/local/share/qt.

How-To-Repeat: % cd /usr/ports/x11-toolkits/qt33
% make install deinstall

...

===>   Deinstalling qt-copy-3.3.8_6
pkg_delete: unable to completely remove directory '/usr/local/share/qt'
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
% ls -la /usr/local/share/qt
total 1
drwxr-xr-x  62 root  wheel  1536 Feb  2 22:27:59 2007 mkspecs/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-01-12 08:10:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Andy Fawcett 2008-01-12 09:55:00 UTC
qmake is a BUILD_DEPENDS for qt33 and not a runtime dependency. This means 
when installing qt33 from a package, qmake is not needed.

If the change suggested is made, the package list would not tidy up the 
filesystem in the "install from package" scenario.

Sorry, I don't think the PR is valid.

Andy
(one of kde@)
Comment 3 Sunpoet Po-Chuan Hsieh 2008-01-12 15:49:05 UTC
On Sat, Jan 12, 2008 at 11:55:00AM +0200, Andy Fawcett wrote:
> qmake is a BUILD_DEPENDS for qt33 and not a runtime dependency. This means 
> when installing qt33 from a package, qmake is not needed.
> 
> If the change suggested is made, the package list would not tidy up the 
> filesystem in the "install from package" scenario.
> 
> Sorry, I don't think the PR is valid.
> 
> Andy
> (one of kde@)

I think your consideration is reasonable.
Since share/qt is not used by qt33 exclusively, how about using @dirrmtry instead?
Thanks.

Sunpoet
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-01-21 18:11:04 UTC
lofi        2008-01-21 18:10:54 UTC

  FreeBSD ports repository

  Modified files:
    x11-toolkits/qt33    pkg-plist 
  Log:
  s/dirrm/dirrmtry for ${PREFIX}/share/qt
  
  PR:             ports/119588
  Submitted by:   Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net>
  
  Revision  Changes    Path
  1.77      +1 -1      ports/x11-toolkits/qt33/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Michael Nottebrock freebsd_committer freebsd_triage 2008-01-21 18:11:13 UTC
State Changed
From-To: open->closed

Replaced dirrm with dirrmtry to silence warning. Thanks for reporting!