Bug 120340 - port irc/ircII broken on amd64/7.0R [patch included]
Summary: port irc/ircII broken on amd64/7.0R [patch included]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-07 10:10 UTC by sec
Modified: 2008-02-21 09:20 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (345 bytes, patch)
2008-02-07 10:10 UTC, sec
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sec 2008-02-07 10:10:00 UTC
irc/ircII is marked broken on RELENG_7 / amd64 with
"doesn't build"

During the build process "mksiginc" core dumps because of a write outside
allocated memory.

The problem is, that it allocates an array of NSIG entries, but writes to
SIGRTMAX. At least on RELENG_7 / amd64, SIGRTMAX is way bigger than NSIG
so this (correctly) fails.

I fixed this, by increasing the array size to SIGRTMAX. ircII appears to
compile and run without any further problems after this fix.

Fix: put the following patch into irc/ircII/files/patch-amd64

and remove the BROKEN= part from the Makefile :-)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-02-07 10:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this category PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-02-07 10:10:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 dfilter service freebsd_committer freebsd_triage 2008-02-21 09:16:15 UTC
beech       2008-02-21 09:16:11 UTC

  FreeBSD ports repository

  Modified files:
    irc/ircII            Makefile 
  Added files:
    irc/ircII/files      patch-source_mksiginc.c 
  Log:
  - Fix build with amd64/7.x
  
  PR:             ports/120340
  Submitted by:   Stefan `Sec` Zehl <sec@42.org>
  Approved by:    maintainer timeout (two weeks)
  
  Revision  Changes    Path
  1.49      +2 -7      ports/irc/ircII/Makefile
  1.1       +15 -0     ports/irc/ircII/files/patch-source_mksiginc.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2008-02-21 09:16:38 UTC
State Changed
From-To: feedback->closed

Committed (maintainer timeout), Thanks!