Port marked as broken on AMD64. Build fails with "R_X86_64_32S" errors. Fix: Compile a52 and mpeg2dec without the -prefer-non-pic flag for libtool. Patch attached with submission follows: How-To-Repeat: Remove broken flag and build port on amd64.
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hi! Thanks for your patch! Sorry for replying so late, I've been very busy lately... Does handbrake really compile and work for you on amd64 with this patch applied? Unfortunately I can't test it myself as I currently don't have an amd64 system running FreeBSD. I submitted a patch with a little different approach which should fix the build on amd64: ports/119908. It works on RELENG_7 but it doesn't seem to work on RELENG_6. However your patch is much more elegant. Could you perhaps test if it works on RELENG_6, too? Best regards, Jona
On Tue, 12 Feb 2008, Jona Joachim wrote: > Hi! > Thanks for your patch! Sorry for replying so late, I've been very busy > lately... > Does handbrake really compile and work for you on amd64 with this patch > applied? Unfortunately I can't test it myself as I currently don't have > an amd64 system running FreeBSD. > I submitted a patch with a little different approach which should fix > the build on amd64: ports/119908. It works on RELENG_7 but it doesn't > seem to work on RELENG_6. However your patch is much more elegant. > Could you perhaps test if it works on RELENG_6, too? Yep, it works fine: [morganw@volatile:/usr/home/media/dvd$]: handbrake -i A_NEW_HOPE -o star_wars.avi HandBrake 0.9.1 (2007100800) - http://handbrake.m0k.org/ 2 CPUs detected Opening A_NEW_HOPE... Scanning title 1... Scanning title 1... Scanning title 1... Scanning title 1... Scanning title 1... Scanning title 1... Scanning title 1... Scanning title 1... <snip> [mpeg4 @ 0x886a20]removing common factors from framerate No accelerated IMDCT transform found Encoding: task 1 of 1, 2.84 % (184.08 fps, avg 191.80 fps, ETA 00h15m09s) [morganw@volatile:/usr/home/media/dvd$]: uname -a FreeBSD volatile 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #4: Sun Jan 13 11:48:41 CST 2008 morganw@volatile:/usr/src/sys/amd64/compile/VOLATILE amd64 It works the same as handbrake on my i386 laptop (Scanning for "forced subs" is broken on both). Unfortunately I don't have a RELENG_6 machine to test it on at the moment. The assembler error messages referenced in your PR look like they are 32-bit specific code that isn't being avoided on amd64.
Responsible Changed From-To: freebsd-ports-bugs->rafan I'll take it.
State Changed From-To: feedback->open Maintainer approved (see Audit-Trail to ports/119008, which he had originally filed; he suggested that 119008 be closed of this one).
rafan 2008-02-20 01:19:09 UTC FreeBSD ports repository Modified files: multimedia/handbrake Makefile Added files: multimedia/handbrake/files patch-contrib-a52dec-configure patch-contrib-mpeg2dec-configure Log: - Unbreak on amd64 7.x and above PR: ports/120510 Submitted by: Wes Morgan <morganw at chemikals.org> Approved by: maintainer Revision Changes Path 1.23 +1 -1 ports/multimedia/handbrake/Makefile 1.1 +11 -0 ports/multimedia/handbrake/files/patch-contrib-a52dec-configure (new) 1.1 +11 -0 ports/multimedia/handbrake/files/patch-contrib-mpeg2dec-configure (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks! (Note that 6.x amd64 is still broken)