Bug 121098 - net-mgmt/nagios-plugins: [PATCH] WITHOUT_NLS=yes actually works
Summary: net-mgmt/nagios-plugins: [PATCH] WITHOUT_NLS=yes actually works
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-25 22:10 UTC by Philip M. Gollucci
Modified: 2008-03-19 14:40 UTC (History)
0 users

See Also:

Attachments
file.diff (761 bytes, patch)
2008-02-25 22:10 UTC, Philip M. Gollucci 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip M. Gollucci 2008-02-25 22:10:00 UTC 
USE_GETTEXT=yes has to be in the conditional.

Also, changed defined() to !defined to match idiom on in porters handbook.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-02-25 22:10:06 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Jarrod Sayers 2008-03-19 12:50:57 UTC 
Approved, though I don't see any gain from altering the WITHOUT_NLS  
logic, so let's leave that as is and just move USE_GETTEXT.

Jarrod.
Comment 3 Rong-En Fan freebsd_committer freebsd_triage 2008-03-19 13:13:53 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2008-03-19 14:31:05 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-03-19 14:31:10 UTC 
rafan       2008-03-19 14:31:02 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/nagios-plugins Makefile 
  Log:
  - USE_GETTEXT should defined only when WITH_NLS
  
  PR:             ports/121098
  Submitted by:   Philip M. Gollucci <pgollucci at p6m7g8.com>
  Approved by:    Jarrod Sayers <jarrod at netleader.com.au> (maintainer)
  
  Revision  Changes    Path
  1.67      +1 -1      ports/net-mgmt/nagios-plugins/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"