Bug 121167 - net/wmwifi - marked broken for wrong reason - its not because of gcc 4.2
Summary: net/wmwifi - marked broken for wrong reason - its not because of gcc 4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-28 06:40 UTC by Dierk Sacher
Modified: 2008-03-14 16:10 UTC (History)
1 user (show)

See Also:

Attachments
wmwifi.patch (3.70 KB, patch)
2008-02-29 19:19 UTC, Ulrich Spoerlein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dierk Sacher 2008-02-28 06:40:04 UTC 

The Port has been marked as broken because of "Does not compile with GCC 4.2". But the compile fails because of the unknown storage size of wi_req which in turn seems to be a result of changes to dev/wi/if_wavelan_ieee.h (#ifdef 0). So this appears rather related to the wifi changes than to the new gcc.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-02-28 06:40:55 UTC 
State Changed
From-To: open->feedback

Which port are you talking about?
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-02-28 08:31:53 UTC 
State Changed
From-To: feedback->open

feedback received
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2008-02-28 08:32:50 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Ulrich Spoerlein 2008-02-29 19:19:26 UTC 
Hi,

I know that the BROKEN line is in itself bogus and I already made a
patch for wmwifi to address the issue on 7.x. I was waiting though, as I
was wondering how many users actually use wmwifi, or if we should simply
drop the port.

Attached is a patch, which has been compile tested on 6.2 and run-tested
on 7.0.

Cheers,
Ulrich Spoerlein
Comment 5 Dierk Sacher 2008-03-05 13:45:29 UTC 
Hi,

thank you for the patch. I'm using it on 7.0 on my X40 now with
Windowmaker. So there is still at least one wmaker user left. Don't know
how many others are still using it these days.

Regards,
Dierk Sacher


Zitiere Ulrich Spoerlein vom Fri, Feb 29, 2008 at 08:19:26PM +0100:
> Hi,
> 
> I know that the BROKEN line is in itself bogus and I already made a
> patch for wmwifi to address the issue on 7.x. I was waiting though, as I
> was wondering how many users actually use wmwifi, or if we should simply
> drop the port.
> 
> Attached is a patch, which has been compile tested on 6.2 and run-tested
> on 7.0.
> 
> Cheers,
> Ulrich Spoerlein



-- 
|----+----|----+----|----+----|----+----|----+----|----+----|----+----|--<
 GPG Fingerprint: D14C 12BB 37A6 6745 7F4F  F420 9E59 D79E A492 2A96
 GPG KeyID      : A4922A96  
+------------------------------------------------------------------------+
Comment 6 Rong-En Fan freebsd_committer freebsd_triage 2008-03-14 16:08:29 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2008-03-14 16:08:40 UTC 
rafan       2008-03-14 16:08:26 UTC

  FreeBSD ports repository

  Modified files:
    net/wmwifi           Makefile 
    net/wmwifi/files     patch-wireless.c 
  Log:
  - Fix build with new net80211 on 7.x and above
  
  PR:             ports/121167
  Submitted by:   Ulrich Spoerlein <uspoerlein at gmail.com> (maintainer)
  Tested by:      Dierk Sacher <dierk at blaxxtarz.de>
  
  Revision  Changes    Path
  1.7       +1 -7      ports/net/wmwifi/Makefile
  1.4       +88 -6     ports/net/wmwifi/files/patch-wireless.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"