I've found an integer multiplication overflow in panel-plugin/memswap.c. When large memory is used, this bug will be triggered, causing the output of this plugin useless. Fix: See my patch. Patch attached with submission follows: How-To-Repeat: Follow these steps when you have more than 3G memory (more than 2G must be enough to exploit this bug, but I have only tried installing 3G memory.) 1. cd /usr/ports/sysutils/xfce4-systemload-plugin && make install 2. Configure xfce4 to enable this plugin. 3. You will see that the output of the memory consumption is absolutely incorrect.
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->miwi I'll take it.
State Changed From-To: feedback->closed Committed. Thanks!
miwi 2008-03-29 23:56:27 UTC FreeBSD ports repository Modified files: sysutils/xfce4-systemload-plugin Makefile Added files: sysutils/xfce4-systemload-plugin/files patch-panel-plugin-memswap.c Log: - Fix memory bug when you have more than 3 GB PR: 121316 Submitted by: MQ <antinvidia@gmail.com> Approved by: maintainer timeout Revision Changes Path 1.25 +1 -2 ports/sysutils/xfce4-systemload-plugin/Makefile 1.1 +24 -0 ports/sysutils/xfce4-systemload-plugin/files/patch-panel-plugin-memswap.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"