Makefile: 1) Variable /etc/shells into ETCSHELLS 2) Use SF Macro 3) Remove files/patch-helper.c (these options are allowed by default now) a) remove PATCH_STRIP 4) Make setup chroot cage instructions cut and pasteable 5) Add secondary category security 6) Add USE_RC_SUBR pkg-descr: 1) Update URL (previous redirects to this) files/scponlyc.in: 1) Convert to RCng style 2) Bug Fix: mount_devfs is not mount -t devfs dev /foo 3) Add a 'stop' to umount devfs systems ports/UPDATING 1) Add note about USE_RC_SUBR
Responsible Changed From-To: freebsd-ports-bugs->rushani Over to maintainer (via the GNATS Auto Assign Tool)
poke.....
I have some questions about this patch: - why have you introduced ETCSHELLS variable to Makefile? It does not seem to serve any purpose, it's not user overridable or anything. I consider it obfuscation. - why have you removed all full paths from rc script? - why sudo in the post-install message? People usually install ports as root anyway. And is the script installed executable? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> Why did the stoplight turn red? You would too, if you had to change in front of all those people.
- why have you introduced ETCSHELLS variable to Makefile? It does not seem to serve any purpose, it's not user overridable or anything. I consider it obfuscation. I was just trying to not repeat it, I have no objections to removing it. - why have you removed all full paths from rc script? doesn't rc.subr set PATH=/bin:/sbin:/usr/bin:/usr/sbin ? before _run_rc_doit() ? - why sudo in the post-install message? People usually install ports as root anyway. And is the script installed executable? Yes, its installed executable. I almost never run as root, but rather use 'sudo'. Seriously, thats not the norm? Anyway, I have no objections to any of the questions you posed, so I can make the necessary changes and resubmit a patch.
Pav, I've change the patch to include your 3 requested modifications. -- ------------------------------------------------------------------------ Philip M. Gollucci (pgollucci@p6m7g8.com) c:703.336.9354 Consultant / http://p6m7g8.net/Resume/resume.txt http://riderway.com / http://ridecharge.com 1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB B89E 1324 9B4F EC88 A0BF Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.
State Changed From-To: open->closed Committed, thanks!
pav 2008-04-03 14:14:28 UTC FreeBSD ports repository Modified files: shells/scponly Makefile distinfo pkg-descr shells/scponly/files scponlyc.in Removed files: shells/scponly/files patch-helper.c Log: - Update to 4.8 PR: ports/121651 Submitted by: Philip M. Gollucci <pgollucci@p6m7g8.com> Approved by: maintainer timeout (rushani; 3 weeks) Revision Changes Path 1.29 +5 -6 ports/shells/scponly/Makefile 1.15 +3 -3 ports/shells/scponly/distinfo 1.2 +0 -97 ports/shells/scponly/files/patch-helper.c (dead) 1.2 +53 -30 ports/shells/scponly/files/scponlyc.in 1.3 +1 -1 ports/shells/scponly/pkg-descr _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"