Bug 121741 - bsd.port.mk - LIB_DEPENDS does not work for libraries with '+' in a name
Summary: bsd.port.mk - LIB_DEPENDS does not work for libraries with '+' in a name
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-15 17:30 UTC by Max Khon
Modified: 2008-04-14 17:50 UTC (History)
0 users

See Also:


Attachments
file.diff (762 bytes, patch)
2008-03-15 17:30 UTC, Max Khon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Khon freebsd_committer freebsd_triage 2008-03-15 17:30:01 UTC
LIB_DEPENDS does not work if library name contains '+'

How-To-Repeat: 
Replace BUILD_DEPENDS/RUN_DEPENDS in audio/esperanza with
appropriate LIB_DEPENDS: the depend does not work -- the xmmsclient++.1 library
can not be found during build.
Comment 1 Rong-En Fan freebsd_committer freebsd_triage 2008-03-16 05:29:00 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr's territory.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2008-03-16 10:23:34 UTC
Tried using xmmsclient\+\+.1 ? There are already examples of this in
ports that depend on say libsigc++ ..

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>
Homer 1. American bonehead 2. Pull a Homer - to succeed despite idiocy
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2008-04-10 15:18:21 UTC
pattern="`${ECHO_CMD} $$lib | ${SED} -E -e 's/\./\\\\./g' -e 's/(\\)?\+/\\\\+/g'`"\

This is the line I'm going to use. It should work with ports that
already escape the plus sign.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Fairy tales do not tell children that dragons exist. Children already
know dragons exist. Fairy tales tell children that dragons can be
killed.
  -- G. K. Chesterton
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2008-04-10 23:47:00 UTC
State Changed
From-To: open->analyzed

Being tested in an exprun
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-04-14 17:46:53 UTC
pav         2008-04-14 16:46:41 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.commands.mk bsd.port.mk 
  Log:
  Support @rmtry in pkg-plist, analogous to @dirrmtry but for single file rm.
  
  PR:             ports/116219
  Submitted by:   edwin
  
  Make USE_DISPLAY more general: set up virtual X server when USE_DISPLAY is
  defined and no DISPLAY variable is in environment; pass DISPLAY value in
  CONFIGURE_ENV and MAKE_ENV.
  
  PR:             ports/116244
  Submitted by:   edwin
  
  Define ${PW}.
  
  PR:             ports/119821
  Submitted by:   Matthew Seaman <m.seaman@infracaninophile.co.uk>
  
  Move SHA256, MD5, GMAKE and XMKMF to bsd.commands.mk.
  
  PR:             ports/119879
  Submitted by:   edwin
  
  Fix a build failure for ports that define their own MTREE File.
  
  PR:             ports/120200
  Submitted by:   dinoex
  
  Don't recreate mtree symlinks if they are already present.
  
  PR:             ports/121681
  Submitted by:   sobomax
  
  Fix LIB_DEPENDS for libraries whose name contains plus sign. Both intuitive and
  old escaped syntax works.
  
  PR:             ports/121741 (based on)
  Submitted by:   fjoe
  
  Disable post-install security checks if DISABLE_SECURITY_CHECK variable is
  defined.
  
  PR:             ports/122224
  Submitted by:   Bjoern Koenig <bkoenig@alpha-tierchen.de>
  
  Remove versioned Tcl/Tk categories.
  
  PR:             ports/122622
  Submitted by:   pav
  
  Revision  Changes    Path
  1.3       +17 -1     ports/Mk/bsd.commands.mk
  1.592     +31 -29    ports/Mk/bsd.port.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2008-04-14 17:47:58 UTC
State Changed
From-To: analyzed->closed

Committed, thanks!