Bug 122574 - mail/kbiff never build with ssl support
Summary: mail/kbiff never build with ssl support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Simon Barner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-08 16:20 UTC by Sven Herschke
Modified: 2008-04-08 21:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Herschke 2008-04-08 16:20:00 UTC
Configure script from port mail/kbiff has following twice and incorrect ssl check between line 25470 and line 25505:

# Check whether --enable-ssl or --disable-ssl was given.
if test "${enable_ssl+set}" = set; then
  enableval="$enable_ssl"
  use_ssl=$enableval
else
  use_ssl=yes
fi;

if test "$use_ssl" == "yes"; then

cat >>confdefs.h <<\_ACEOF
#define USE_SSL
_ACEOF

fi


# Check whether --enable-ssl or --disable-ssl was given.
if test "${enable_ssl+set}" = set; then
  enableval="$enable_ssl"
  use_ssl=$enableval
else
  use_ssl=yes
fi;

if test "$use_ssl" == "yes"; then

cat >>confdefs.h <<\_ACEOF
#define USE_SSL
_ACEOF

fi


The syntax error is in following code:
if test "$use_ssl" == "yes"; then

String comparsion with test only needs one equals sign.

Fix: 

Remove twice code and change line 
    if test "$use_ssl" == "yes"; then
to
    if test "$use_ssl" = "yes"; then
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-04-08 16:20:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->barner

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-04-08 21:23:27 UTC
barner      2008-04-08 20:23:18 UTC

  FreeBSD ports repository

  Modified files:
    mail/kbiff           Makefile 
  Added files:
    mail/kbiff/files     patch-configure 
  Log:
  - Fix SSL support
  - Bump port revision
  
  PR:             ports/122574
  Submitted by:   Sven Herschke
  
  Revision  Changes    Path
  1.47      +12 -2     ports/mail/kbiff/Makefile
  1.3       +20 -0     ports/mail/kbiff/files/patch-configure (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Simon Barner freebsd_committer freebsd_triage 2008-04-08 21:23:44 UTC
State Changed
From-To: open->closed

Committed. Thanks!