Bug 123437 - comms/qpage -- hangup problems and ident requests
Summary: comms/qpage -- hangup problems and ident requests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-05 22:30 UTC by rand
Modified: 2008-10-24 11:16 UTC (History)
0 users

See Also:


Attachments
file.diff (410 bytes, patch)
2008-05-05 22:30 UTC, rand
no flags Details | Diff
file.diff (237 bytes, patch)
2008-05-05 22:30 UTC, rand
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rand 2008-05-05 22:30:00 UTC
	If you set identtimeout to 0 it is supposed to supress getting
	the submitting user. It does stop qpage from explicitly making
	its own ident request, but it doesn't stop qpage from having
	TCP Wrappers make the request for it.

	Also, at times we end up with the modem not getting hung up.
	There is a logic error where it tries to hangup the modem 
	by dropping DTR and setting the line speed to 0. But it then
	executes a return from the function, skipping the very next
	check which is to see if carrier detect is still present, and
	then trying to hang up the modem with "+++" and then a "ATH0".

	Both patches have been submitted to the qpage author.

Fix: The attached patches.

How-To-Repeat: 	For ident, use qpage via a firewall that is dropping ident
	packets, it takes 10 seconds to establish the connection.

	For the hangup I am not able to routinely recreate the problem
	of the modem not hanging up, but I still believe there is a
	logic error in the code.
Comment 1 Stefan Walter freebsd_committer freebsd_triage 2008-10-18 19:42:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 2 Stefan Walter freebsd_committer freebsd_triage 2008-10-22 09:54:05 UTC
Dear maintainer of comms/qpage,

a problem report has been submitted for your port for which your 
feedback might be required; its contents can be found at [1]. If it 
contains a patch or suggestions for a change, please send a followup to 
the PR explaining whether or not you approve it and want it to be 
committed.

Regards,
Stefan

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/123437
Comment 3 jfb 2008-10-23 18:03:39 UTC
Douglas, thank you for your submission.  I'm approving the patches you
submitted with your PR, but I've actually incorporated them into
another PR, one I submitted earlier today with a number of other
changes I had to make.  (See
http://www.freebsd.org/cgi/query-pr.cgi?pr=128318 )  One note on the
srvrsnpp.c patch: since I can see a situation where an administrator
might wish to allow libwrap to perform ident lookups even while
leaving them disabled in qpage, I've made that patch optional via a
Makefile variable.  ixo.c will be patched for everyone
unconditionally.

Stefan, there is no further action to be taken with the PR other than
to close it and commit the diff in ports/128318.  Thank you.

Jeff Blank
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2008-10-24 11:15:15 UTC
State Changed
From-To: open->closed

Committed along with ports/128318, thanks!