If you set identtimeout to 0 it is supposed to supress getting the submitting user. It does stop qpage from explicitly making its own ident request, but it doesn't stop qpage from having TCP Wrappers make the request for it. Also, at times we end up with the modem not getting hung up. There is a logic error where it tries to hangup the modem by dropping DTR and setting the line speed to 0. But it then executes a return from the function, skipping the very next check which is to see if carrier detect is still present, and then trying to hang up the modem with "+++" and then a "ATH0". Both patches have been submitted to the qpage author. Fix: The attached patches. How-To-Repeat: For ident, use qpage via a firewall that is dropping ident packets, it takes 10 seconds to establish the connection. For the hangup I am not able to routinely recreate the problem of the modem not hanging up, but I still believe there is a logic error in the code.
Responsible Changed From-To: freebsd-ports-bugs->stefan Take.
Dear maintainer of comms/qpage, a problem report has been submitted for your port for which your feedback might be required; its contents can be found at [1]. If it contains a patch or suggestions for a change, please send a followup to the PR explaining whether or not you approve it and want it to be committed. Regards, Stefan [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/123437
Douglas, thank you for your submission. I'm approving the patches you submitted with your PR, but I've actually incorporated them into another PR, one I submitted earlier today with a number of other changes I had to make. (See http://www.freebsd.org/cgi/query-pr.cgi?pr=128318 ) One note on the srvrsnpp.c patch: since I can see a situation where an administrator might wish to allow libwrap to perform ident lookups even while leaving them disabled in qpage, I've made that patch optional via a Makefile variable. ixo.c will be patched for everyone unconditionally. Stefan, there is no further action to be taken with the PR other than to close it and commit the diff in ports/128318. Thank you. Jeff Blank
State Changed From-To: open->closed Committed along with ports/128318, thanks!