Bug 123849 - [PATCH] update for multimedia/handbrake
Summary: [PATCH] update for multimedia/handbrake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-21 05:10 UTC by jonathan
Modified: 2008-07-17 22:10 UTC (History)
0 users

See Also:


Attachments
file.diff (9.51 KB, patch)
2008-05-21 05:10 UTC, jonathan
no flags Details | Diff
handbrake_0.9.2.diff (19.40 KB, patch)
2008-06-04 07:10 UTC, jonathan
no flags Details | Diff
handbrake_0.9.2.diff (19.40 KB, patch)
2008-06-09 18:13 UTC, jonathan
no flags Details | Diff
handbrake.diff (23.72 KB, patch)
2008-06-17 22:31 UTC, Jona Joachim
no flags Details | Diff
handbrake.diff (23.72 KB, patch)
2008-06-17 22:31 UTC, Jona Joachim
no flags Details | Diff
handbrake.diff (23.72 KB, patch)
2008-07-14 18:27 UTC, Jona Joachim
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jonathan 2008-05-21 05:10:02 UTC
Update multimedia/handbrake to the latest release, patches included.

Fix: This update has been verified to compile correctly on my system.

Replace the current patch-contrib-Jamfile with the attached one and apply the patch below to the Makefile

--- Makefile.orig       2008-05-21 04:07:46.000000000 +0300
+++ Makefile    2008-05-21 06:28:42.000000000 +0300
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=      handbrake
-PORTVERSION=   0.9.1
+PORTVERSION=   0.9.2
 CATEGORIES=    multimedia
 MASTER_SITES=  http://saintdevelopment.com/mirror/handbrake/:main \
                http://junk.phantomgorilla.com/hb/:main \
@@ -21,14 +21,14 @@
                libdca-r81-strapped.tar.gz:contrib \
                libdvdcss-1.2.9.tar.gz:contrib \
                libdvdread-0.9.7.tar.gz:contrib \
-               libmkv-0.6.1.2.tar.gz:contrib \
+               libmkv-0.6.1.3.tar.gz:contrib \
                libogg-1.1.2.tar.gz:contrib \
                libvorbis-aotuv_b5.tar.gz:contrib \
                mpeg2dec-0.4.1.tar.gz:contrib \
                mpeg4ip-1.3.tar.gz:contrib \
                xvidcore-1.1.2.tar.gz:contrib \
                ffmpeg-9816.tar.gz:contrib \
-               x264-r665.tar.gz:contrib \
+               x264-r736.tar.gz:contrib \
                a52dec-0.7.4.tar.gz:contrib \
                libsamplerate-0.1.2.tar.gz:contrib
 DIST_SUBDIR=   handbrake



Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-21 05:10:06 UTC
Maintainer of multimedia/handbrake,

Please note that PR ports/123849 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/123849

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-21 05:10:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 jonathan 2008-06-04 07:10:04 UTC
A revised patch for .9.2 is attached using diff -ruN this time.

I am also volunteering to take over maintainership of the port if the 
current maintainer approves this patch and an ownership change.

Jonathan Stewart
Comment 4 Jona Joachim 2008-06-04 19:32:32 UTC
does this actually build for you?
I get several build errors.

Here's a complete build log:
http://www.hcl-club.lu/~jaj/stuff/handbrake-0.9.2_buildlog

uname -a
FreeBSD nirvana.my.domain 7.0-STABLE FreeBSD 7.0-STABLE #0: Wed May 28 19:35:33 CEST 2008     root@nirvana.my.domain:/usr/obj/usr/src/sys/HYPOCENTER  i386
Comment 5 jonathan 2008-06-05 06:14:49 UTC
On Wed, June 4, 2008 14:32, Jona Joachim wrote:
> does this actually build for you? I get several build errors.
>
>
> Here's a complete build log:
> http://www.hcl-club.lu/~jaj/stuff/handbrake-0.9.2_buildlog

I have a build log up at http://iraq.kc8onw.net/handbrake_.9.2.log now. 
Our logs differ after a bit, yours has

Making all in autotools
cd: can't cd to autotools
gmake: *** [all-recursive] Error 1

While mine has

Making all in autotools
gmake[1]: Entering directory
`/usr/ports/multimedia/handbrake/work/HandBrake/contrib/a52dec/autotools'

I don't know why it would be doing this though.  I won't be able to look
into it for a couple of days but I will try and see if I missed something
on my end when I get a chance.  (This log is from a build I did after
receiving your email)

Jonathan
Comment 6 jonathan 2008-06-09 18:13:47 UTC
On Thu, June 5, 2008 01:14, jonathan@kc8onw.net wrote:
> On Wed, June 4, 2008 14:32, Jona Joachim wrote:
>
>> does this actually build for you? I get several build errors.

I just blew away my ports tree, recreated it, and applied the patch.  It
built without problems again.  I'll attach the patch I used to this email
in case something got messed up last time.

Jonathan Stewart
Comment 7 Jona Joachim 2008-06-17 22:31:53 UTC
The following patch is based on the submitter's diff and does:

- Update multimedia/handbrake to 0.9.2 (current release).
- Make some patches upstream-friendlier.
- Remove some private mirrors (which we shouldn't have in the port according to
  the devs).
- Mark broken on amd64. Some people reported trouble (even though it should
  build fine). Neither submitter nor me can test on this platform.
- Pass maintainership to the submitter.

Best regards,
Jona (current maintainer)
Comment 8 Jona Joachim 2008-06-17 22:31:53 UTC
The following patch is based on the submitter's diff and does:

- Update multimedia/handbrake to 0.9.2 (current release).
- Make some patches upstream-friendlier.
- Remove some private mirrors (which we shouldn't have in the port according to
  the devs).
- Mark broken on amd64. Some people reported trouble (even though it should
  build fine). Neither submitter nor me can test on this platform.
- Pass maintainership to the submitter.

Best regards,
Jona (current maintainer)
Comment 9 Jona Joachim 2008-07-14 18:27:31 UTC
I resend this follow-up because GNATS mangeled my first submit...
I hope it shows fine this time.

The following patch is based on the submitter's diff and does:
 
- Update multimedia/handbrake to 0.9.2 (current release).
- Make some patches upstream-friendlier.
- Remove some private mirrors (which we shouldn't have in the port according to
  the devs).
- Mark broken on amd64. Some people reported trouble (even though it should
  build fine). Neither submitter nor me can test on this platform.
- Pass maintainership to the submitter.
 
Best regards,
Jona (current maintainer)
Comment 10 dfilter service freebsd_committer freebsd_triage 2008-07-17 22:06:24 UTC
erwin       2008-07-17 21:06:11 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/handbrake Makefile distinfo pkg-descr 
    multimedia/handbrake/files patch-contrib-Jamfile 
                               patch-libhb-fifo.c 
                               patch-libhb-ports.c 
  Removed files:
    multimedia/handbrake/files patch-contrib-mpeg4ip-configure 
  Log:
   - Update multimedia/handbrake to 0.9.2 (current release).
   - Make some patches upstream-friendlier.
   - Remove some private mirrors (which we shouldn't have in the port according to
     the devs).
   - Mark broken on amd64. Some people reported trouble (even though it should
     build fine). Neither submitter nor me can test on this platform.
   - Pass maintainership to the submitter.
  
  PR:             123849
  Submitted by:   Jona Joachim <jaj@hcl-club.lu> (old maintainer),
                  Jonathan Stewart <jonathan@kc8onw.net> (new maintainer)
  
  Revision  Changes    Path
  1.24      +9 -12     ports/multimedia/handbrake/Makefile
  1.5       +9 -9      ports/multimedia/handbrake/distinfo
  1.2       +92 -126   ports/multimedia/handbrake/files/patch-contrib-Jamfile
  1.2       +0 -11     ports/multimedia/handbrake/files/patch-contrib-mpeg4ip-configure (dead)
  1.2       +7 -7      ports/multimedia/handbrake/files/patch-libhb-fifo.c
  1.2       +19 -22    ports/multimedia/handbrake/files/patch-libhb-ports.c
  1.4       +1 -1      ports/multimedia/handbrake/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 11 Erwin Lansing freebsd_committer freebsd_triage 2008-07-17 22:06:27 UTC
State Changed
From-To: feedback->closed

Committed, thanks!