PR: ports/96263 introduced command line option -b to bind client socket to an address for outgoing connection. It did not allow to bind it to address differing from server address, though. The code in files/patch-02 uses 'fallthrough' featue of C 'case' statement. Next port's PR: ports/113069 broke this code. Fix: Recover breakage from ports/113069 and, at last, make it possible to connect using specified address that differs from server one. This patch corrects files/patch-02 to the kind it should be at first. The file files/patch-03 is touched just due to context changes, its own affects are the same. How-To-Repeat: bounce -a 192.168.0.1 -b 100.100.100.100 -p 10000 remotehost 1000 This won't connect to remotehost from 100.100.100.100, it rather connect from 192.168.0.1, that's bad.
Maintainer of net/bounce, Please note that PR ports/124062 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124062 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hi! Maintainer timeout has occured for this PR long time ago. Please commit the patch. Eugene Grosbein
lippe 2008-09-02 19:05:13 UTC FreeBSD ports repository Modified files: net/bounce Makefile Added files: net/bounce/files patch-bounce.c Removed files: net/bounce pkg-plist net/bounce/files patch-01 patch-02 patch-03 patch-04 Log: - Fix source bind address using -b option. - Use PLIST_FILES instead of pkg-plist. - The patches were merged. - Bump PORTREVISION. PR: ports/124062 Submitted by: Eugene Grosbein <eugen@kuzbass.ru> Approved by: maintainer timeout (>2 weeks) Revision Changes Path 1.25 +4 -3 ports/net/bounce/Makefile 1.4 +0 -149 ports/net/bounce/files/patch-01 (dead) 1.3 +0 -52 ports/net/bounce/files/patch-02 (dead) 1.2 +0 -44 ports/net/bounce/files/patch-03 (dead) 1.3 +0 -58 ports/net/bounce/files/patch-04 (dead) 1.1 +224 -0 ports/net/bounce/files/patch-bounce.c (new) 1.4 +0 -2 ports/net/bounce/pkg-plist (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!