Bug 124063 - audio/aureal-kmod lacks proper rcNG startup script
Summary: audio/aureal-kmod lacks proper rcNG startup script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-28 14:00 UTC by c.kworr
Modified: 2008-06-15 07:10 UTC (History)
0 users

See Also:

Attachments
file.txt (1.87 KB, text/plain)
2008-05-28 14:00 UTC, c.kworr 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description c.kworr 2008-05-28 14:00:11 UTC 
Supplied aureal.sh lacks knobs needed for rcNG to recognize and to start it automatically.

Fix: I have prepared a script on my own.

Patch attached with submission follows:
How-To-Repeat: Just install the port. You end up running '/usr/local/etc/rc.d/aureal.sh start' each time you boot up.
Comment 1 Rong-En Fan freebsd_committer freebsd_triage 2008-06-01 05:35:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 2 Rong-En Fan freebsd_committer freebsd_triage 2008-06-04 03:47:58 UTC 
State Changed
From-To: open->feedback

(mail sent on Jun 1, posted here in case it was not delivered) 

Hi Volodymyr, 

Thanks for the submission. I did some cleanup and add few 
things. Enclosed please find the new patch [1]. 

Would you please verify this work as expected? 

[1] http://people.freebsd.org/~rafan/aureal-kmod.diff
Comment 3 c.kworr 2008-06-06 09:28:49 UTC 
Sorry for the delay.

Yes the proposed patch works for me and thank you for cleaning up things 
a bit.

PS: Just one thing. I'm not used to FSTND and port infrastructure, but 
wouldn't it be better to place compiled modules in /usr/local/modules 
like sysutils/fuse-kmod or in /boot/modules like emulators/kqemu-kmod 
and x11/nvidia-drivers do?

-- 
Sphinx of black quartz judge my vow.
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-06-15 07:09:17 UTC 
rafan       2008-06-15 06:09:13 UTC

  FreeBSD ports repository

  Modified files:
    audio/aureal-kmod    Makefile pkg-plist 
  Added files:
    audio/aureal-kmod/files aureal.in pkg-message.in 
  Removed files:
    audio/aureal-kmod    pkg-message 
    audio/aureal-kmod/files aureal.sh 
  Log:
  - Convert old style rc script to the new world order
  - Install kernel modules in PREFIX/modules instead of PREFIX/lib
  - Bump PORTREVISION
  
  PR:             ports/124063 (based on)
  Submitted by:   Volodymyr Kostyrko <c.kworr at gmail.com>
  Tested by:      Volodymyr Kostyrko <c.kworr at gmail.com> (earlier version)
  
  Revision  Changes    Path
  1.32      +12 -9     ports/audio/aureal-kmod/Makefile
  1.1       +96 -0     ports/audio/aureal-kmod/files/aureal.in (new)
  1.4       +0 -82     ports/audio/aureal-kmod/files/aureal.sh (dead)
  1.1       +37 -0     ports/audio/aureal-kmod/files/pkg-message.in (new)
  1.6       +0 -38     ports/audio/aureal-kmod/pkg-message (dead)
  1.5       +8 -7      ports/audio/aureal-kmod/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Rong-En Fan freebsd_committer freebsd_triage 2008-06-15 07:09:21 UTC 
State Changed
From-To: feedback->closed

Committed with changes. Thanks!