Bug 124226 - [PATCH] ports-mgmt/psearch: fix psearch does not work
Summary: [PATCH] ports-mgmt/psearch: fix psearch does not work
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-03 04:10 UTC by Yi-Huan Chan
Modified: 2008-06-04 04:30 UTC (History)
1 user (show)

See Also:

Attachments
psearch-2.0_1.patch (1.35 KB, patch)
2008-06-03 04:10 UTC, Yi-Huan Chan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yi-Huan Chan 2008-06-03 04:10:01 UTC 
The function Index::parse_line() should return 'true', or psearch may not work.

Added file(s):
- files/patch-index.cpp

Port maintainer (mail@maxlor.com) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-03 04:10:06 UTC 
Maintainer of ports-mgmt/psearch,

Please note that PR ports/124226 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124226

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-03 04:10:08 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Benjamin Lutz 2008-06-03 08:30:59 UTC 
Hello,

The PR is rejected. The submitter of the patch, Yi-Huan Chan is correct in 
that the problem exists (and how he suggests it be fixed), however I'd rather 
roll the patch into a new upstream tarball instead of having it live solely 
inside the ports system. I'll send a corresponding PR shortly.

Yi-Huan Chan: Thanks for the code review!

Cheers
Benjamin
Comment 4 Li-Wen Hsu freebsd_committer freebsd_triage 2008-06-03 11:42:28 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lwhsu

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-06-04 04:25:41 UTC 
lwhsu       2008-06-04 03:25:35 UTC

  FreeBSD ports repository

  Modified files:
    ports-mgmt/psearch   Makefile distinfo 
  Log:
  - Update to 2.0.1, this update fixed the functionality of psearch
  
  PR:             ports/124226 (based on the patch)
  Submitted by:   Yi-Huan Chan <yhchan AT csie.nctu.edu.tw>
  Approved by:    Benjamin Lutz <mail AT maxlor.com> (maintainer)
  
  Revision  Changes    Path
  1.6       +1 -1      ports/ports-mgmt/psearch/Makefile
  1.5       +3 -3      ports/ports-mgmt/psearch/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2008-06-04 04:25:48 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!