audio/mp3splt segfaults if a vorbis file is split after a mp3 file. The attached patch prevents that. I already reported the problem upstream: https://sourceforge.net/tracker/?func=detail&atid=476061&aid=1953386&group_id=55130 but it seems that they are busy rewriting mp3splt, thus the old one is no longer actively maintained and waiting for a new release may take a while. Fix: Patch attached with submission follows: How-To-Repeat: fk@TP51 /tank/iriver-spiegel/podcasts/split $mp3splt -t 5.00 ../bsdtalk14* Mp3Splt 2.1c (2005/Apr/03) by Matteo Trotta <matteo.trotta@lib.unimib.it> THIS SOFTWARE COMES WITH ABSOLUTELY NO WARRANTY! USE AT YOUR OWN RISK! ./bsdtalk143.mp3: MPEG 1 Layer 3 - 44100 Hz - Mono - 64 Kb/s - Total time: 22m.45s Splitting bsdtalk143_000.00_005.00.mp3... OK [...] Splitting bsdtalk143_020.00_025.00.mp3... OK (WARNING) Warning: mp3 might be VBR. You should use -f option. ./bsdtalk143.ogg: Ogg Vorbis Stream - 44100 - 93 Kb/s - 1 channels - Total time: 22m.45s Splitting bsdtalk143_000.00_005.00.ogg... OK [...] Splitting bsdtalk143_020.00_025.00.ogg... OK (EOF) ./bsdtalk144.mp3: Segmentation fault: 11 (core dumped)
Maintainer of audio/mp3splt, Please note that PR ports/124616 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124616 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hi Fabian, looks ok to me. Might you even be interessted in maintaining the port? Cheers, Ulrich Spoerlein
Ulrich Spoerlein <uspoerlein@gmail.com> wrote: > looks ok to me. Might you even be interessted in maintaining the port? Sure, thanks. The attached patch additionally changes MAINTAINER to my address. Fabian
State Changed From-To: feedback->open Maintainer has approved.
adamw 2008-06-25 04:25:32 UTC FreeBSD ports repository Modified files: audio/mp3splt Makefile Added files: audio/mp3splt/files patch-mp3splt.c Log: Add a fix to prevent a segfault when an mp3 file is followed by a Vorbis file. Transfer maintainership to the submitter, at the request of the previous maintainer. PR: ports/124616 Submitted by: Fabian Keil <fk@fabiankeil.de> Approved by: Original maintainer (uspoerlein@mgail.com) Revision Changes Path 1.21 +2 -2 ports/audio/mp3splt/Makefile 1.1 +16 -0 ports/audio/mp3splt/files/patch-mp3splt.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks! Maintainership has also been transferred per request.