Bug 124674 - [patch] www/mod_lisp2: FIX: Generates incorrect LoadModule directive in apache22's httpd.conf
Summary: [patch] www/mod_lisp2: FIX: Generates incorrect LoadModule directive in apach...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-17 16:20 UTC by Sven Klose
Modified: 2008-06-21 13:40 UTC (History)
0 users

See Also:


Attachments
file.shar (2.20 KB, text/plain)
2008-06-17 16:20 UTC, Sven Klose
no flags Details
mod_lisp2.shar.txt (2.81 KB, text/plain)
2008-06-17 17:00 UTC, Sven Klose
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Klose 2008-06-17 16:20:03 UTC
The following line is inserted into httpd.conf

#LoadModule lisp2_module       libexec/apache22/mod_lisp2.so

which is incorrect, because the symbol 'lisp_module' is used in mod_lisp2.c instead of 'lisp2_module'.

The attached version adds a patch to fix the symbol name in the source file.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-17 16:20:11 UTC
Maintainer of www/mod_lisp2,

Please note that PR ports/124674 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124674

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-17 16:20:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Sven Klose 2008-06-17 17:00:27 UTC
I messed up. Here's a more sane version of the fix.
Comment 4 viktor.leis 2008-06-17 18:07:59 UTC
bugfix is ok.

--
Viktor Leis
Comment 5 Viktor Leis 2008-06-17 18:11:04 UTC
I approve the patch.

Viktor Leis
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-06-21 13:36:48 UTC
miwi        2008-06-21 12:36:42 UTC

  FreeBSD ports repository

  Modified files:
    www/mod_lisp2        Makefile 
  Added files:
    www/mod_lisp2/files  patch-mod_lisp2.c 
  Log:
  - Fix generates incorrect LoadModule directive in apache22's httpd.conf
  
  PR:             124674
  Submitted by:   Sven Klose <pixel@copei.de>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.2       +1 -0      ports/www/mod_lisp2/Makefile
  1.1       +29 -0     ports/www/mod_lisp2/files/patch-mod_lisp2.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Martin Wilke freebsd_committer freebsd_triage 2008-06-21 13:37:09 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!