Bug 124829 - port upgrade and unbreak: net/whois 4.7.26
Summary: port upgrade and unbreak: net/whois 4.7.26
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Felippe de Meirelles Motta
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-21 14:10 UTC by Lapo Luchini
Modified: 2008-07-18 14:40 UTC (History)
1 user (show)

See Also:


Attachments
pr-whois (2.85 KB, text/plain)
2008-06-21 14:10 UTC, Lapo Luchini
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lapo Luchini 2008-06-21 14:10:01 UTC
Current version is broken (doesn't fetch).

Here is a quick attemp to solve the problem.

I switched to "USE_GMAKE" because I don't know how to convert "-include" (which is 
present in the program's Makefile since this release) to BSD make language.
This adds a (quite common) build-dependency but simplify patches.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-21 14:10:05 UTC
Maintainer of net/whois,

Please note that PR ports/124829 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124829

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-21 14:10:06 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2008-06-21 19:23:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lippe

I'll take it.
Comment 4 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2008-07-06 02:17:13 UTC
Hi maintainer,

This new version is broken, does not compile on my box
(amd64/7-STABLE), look below:

===> whois-4.7.26 depends on shared
library: intl
- found ===>  Configuring for whois-4.7.26
===>  Building for whois-4.7.26
cc -O2 -fno-strict-aliasing -pipe  -MM -MG *.c > Makefile.depend
perl -w make_ip_del.pl < ip_del_list > ip_del.h
perl -w make_ip6_del.pl < ip6_del_list > ip6_del.h
perl -w make_as_del.pl < as_del_list > as_del.h
perl -w make_tld_serv.pl < tld_serv_list > tld_serv.h
cc -O2 -fno-strict-aliasing -pipe   -c whois.c
In file included from whois.c:38:
utils.h:30:22: error: libintl.h: No such file or directory
whois.c: In function 'main':
whois.c:118: warning: incompatible implicit declaration of built-in
function 'gettext' whois.c: In function 'handle_query':
whois.c:210: warning: incompatible implicit declaration of built-in
function 'gettext' whois.c:274: warning: incompatible implicit
declaration of built-in function 'gettext' whois.c:285: warning:
incompatible implicit declaration of built-in function 'gettext'
whois.c: In function 'queryformat': whois.c:483: warning: incompatible
implicit declaration of built-in function 'gettext' whois.c: In
function 'do_query': whois.c:621: warning: incompatible implicit
declaration of built-in function 'gettext' whois.c: In function
'query_afilias': whois.c:756: warning: incompatible implicit
declaration of built-in function 'gettext' whois.c: In function
'alarm_handler': whois.c:826: warning: incompatible implicit
declaration of built-in function 'gettext' whois.c: In function
'sighandler': whois.c:832: warning: incompatible implicit declaration
of built-in function 'gettext' whois.c: In function 'usage':
whois.c:1001: warning: incompatible implicit declaration of built-in
function 'gettext' gmake: ** [whois.o] Erro 1
*** Error code 2

Can you try to fix it and send us again ? Thanks!

-- 
lippe@FreeBSD.org
Felippe de Meirelles Motta
Comment 5 Lapo Luchini 2008-07-15 14:35:56 UTC
> Hi maintainer,
> This new version is broken, does not compile on my box
> (amd64/7-STABLE)

Uhm, I'm not the maintainer, so I'm not sure this was meant for me, but 
FWIW it does compile (and work) on my amd64/6.3-PRERELEASE.
Did you use WITHOUT_NLS or something? (which should be supported anywaysâ¦)
Comment 6 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2008-07-15 16:02:27 UTC
State Changed
From-To: feedback->open

feedback received.
Comment 7 dfilter service freebsd_committer freebsd_triage 2008-07-18 14:32:13 UTC
lippe       2008-07-18 13:32:04 UTC

  FreeBSD ports repository

  Modified files:
    net/whois            Makefile distinfo pkg-plist 
    net/whois/files      patch-aa 
  Log:
  - Update to 4.7.26.
  - Unbreak.
  
  PR:             ports/124829
  Submitted by:   Lapo Luchini <lapo@lapo.it>
  Approved by:    gabor (mentor, implicit), maintainer timeout (>2 weeks)
  
  Revision  Changes    Path
  1.48      +2 -4      ports/net/whois/Makefile
  1.38      +3 -3      ports/net/whois/distinfo
  1.10      +15 -25    ports/net/whois/files/patch-aa
  1.9       +2 -0      ports/net/whois/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Felippe de Meirelles Motta freebsd_committer freebsd_triage 2008-07-18 14:34:39 UTC
State Changed
From-To: open->closed

Committed. Thanks!