Bug 124841 - [PATCH] devel/zthread: Fix signature in BlockingQueue.h
Summary: [PATCH] devel/zthread: Fix signature in BlockingQueue.h
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-21 18:50 UTC by Michael
Modified: 2009-04-24 04:00 UTC (History)
1 user (show)

See Also:


Attachments
zthread-2.3.2_1.patch (1.91 KB, patch)
2008-06-21 18:50 UTC, Michael
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 2008-06-21 18:50:00 UTC
Two patches, one to fix a signed to unsigned comparison in Barrier.h and
more importantly a fix of the signature of the overloaded 
bool BlockingQueue::add(item, timeout) member function in BlockingQueue.h, 
which rendered using the feature impossible.

Since my previous attempts to contact Eric about other patches were not
successful and therefore I do not expect new releases of ZThread anytime in
the near future, I suggest fixing this in the port skeleton.

Portlint complained about an old README.html in the port as well, you might 
consider removing this when applying these patches.

Added file(s):
- files/patch-include_zthread_Barrier.h
- files/patch-include_zthread_BlockingQueue.h

Port maintainer (shaun@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-21 18:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->shaun

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Shaun Amott freebsd_committer freebsd_triage 2009-03-13 23:34:43 UTC
Responsible Changed
From-To: shaun->freebsd-ports-bugs

No longer my port.
Comment 3 Greg Larkin freebsd_committer freebsd_triage 2009-04-23 21:22:26 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glarkin

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-04-24 03:52:57 UTC
glarkin     2009-04-24 02:52:45 UTC

  FreeBSD ports repository

  Modified files:
    devel/zthread        Makefile 
  Added files:
    devel/zthread/files  patch-include__zthread__Barrier.h 
                         patch-include__zthread__BlockingQueue.h 
                         patch-include__zthread__Guard.h 
                         patch-src__MutexImpl.h 
  Removed files:
    devel/zthread/files  patch-include_zthread_Guard.h 
                         patch-src_MutexImpl.h 
  Log:
  - Added patch to fix signature in BlockingQueue.h
  - Take maintainership
  - Bump PORTREVISION
  - Minor Makefile style cleanups
  - Regenerated patch files with "make makepatch"
  
  PR:             ports/124841
  Submitted by:   Michael <freebsdports at bindone dot de>
  
  Revision  Changes    Path
  1.25      +5 -5      ports/devel/zthread/Makefile
  1.1       +20 -0     ports/devel/zthread/files/patch-include__zthread__Barrier.h (new)
  1.1       +11 -0     ports/devel/zthread/files/patch-include__zthread__BlockingQueue.h (new)
  1.1       +11 -0     ports/devel/zthread/files/patch-include__zthread__Guard.h (new)
  1.2       +0 -11     ports/devel/zthread/files/patch-include_zthread_Guard.h (dead)
  1.2       +0 -83     ports/devel/zthread/files/patch-src_MutexImpl.h (dead)
  1.1       +83 -0     ports/devel/zthread/files/patch-src__MutexImpl.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Greg Larkin freebsd_committer freebsd_triage 2009-04-24 03:54:03 UTC
State Changed
From-To: open->closed

Committed, thank you!