Bug 125905 - [Maintainer-update] sysutils/flexbackup: patch set incorporation
Summary: [Maintainer-update] sysutils/flexbackup: patch set incorporation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Greg Larkin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-23 18:00 UTC by Marcus von Appen
Modified: 2008-07-30 22:10 UTC (History)
0 users

See Also:


Attachments
flexbackup-1.2.1_3.patch (25.69 KB, patch)
2008-07-23 18:00 UTC, Marcus von Appen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus von Appen freebsd_committer freebsd_triage 2008-07-23 18:00:08 UTC
This adds various patches from the Gentoo repository to the flexbackup
port. Those include:

- Tempfile security fixes
- LZMA compression support
- Patches for bash3 usage
- Remote buffer usage fixes
- Fixes for filenames with spaces.
- Fixes for large files and afio usage.
- Pruning fixes.

It also adds a new link to additional configuration information in
pkg-descr.

Added file(s):
- files/patch-flexbackup
- files/patch-flexbackup.1
- files/patch-flexbackup.conf.5

Generated with FreeBSD Port Tools 0.77
Comment 1 Greg Larkin freebsd_committer freebsd_triage 2008-07-25 16:26:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glarkin

I'll take it.
Comment 2 Greg Larkin freebsd_committer freebsd_triage 2008-07-25 19:41:47 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Marcus,

Thank you for your PR.  I have reviewed your patch and made some minor
changes:

- - Removed CONFDIR usage, since it can be replaced with PREFIX, and it's
not used in the flexbackup script itself.

- - Moved pkg-message to files/pkg-message.in and use SUB_FILES to perform
variable substitution instead of the post-configure target.

- - Added commands to do-install to create a flexbackup.conf file if one
doesn't already exist.  The target will also preserve a flexbackup.conf
file that's different than flexbackup.conf.sample when the port is
deinstalled.  Reworded pkg-message.in so it makes sense in the context
of this change.

- - Replaced the for loop with COPYTREE_SHARE macro when installing
documentation.

- - Updated pkg-plist to handle the do-install target enhancements.

When you have a chance, please review the diff between my patch and the
one you filed with the PR:

http://people.freebsd.org/~glarkin/diffs/flexbackup-vs-submitted.diff

If you need it, this is a diff of my patch vs. the CVS repository:

http://people.freebsd.org/~glarkin/diffs/flexbackup-vs-CVS.diff

Let me know what you think, and if the changes look good to you, I'll
send them to my mentor for approval.

Best regards,
Greg
- --
Greg Larkin
http://www.sourcehosting.net/
http://www.FreeBSD.org/ - The Power To Serve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIih5r0sRouByUApARAu+dAKCNwgARiuIXPKX2qr2UPuw0Ruo5ogCgsA7+
YSWRTA4u8YG5GncmB/IcHh0=
=NqyA
-----END PGP SIGNATURE-----
Comment 3 Greg Larkin freebsd_committer freebsd_triage 2008-07-30 22:02:54 UTC
State Changed
From-To: open->closed

Committed with slight Makefile changes, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-07-30 22:02:54 UTC
glarkin     2008-07-30 21:02:40 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/flexbackup  Makefile pkg-descr 
    sysutils/flexbackup/files patch-flexbackup.conf 
  Added files:
    sysutils/flexbackup/files patch-flexbackup patch-flexbackup.1 
                              patch-flexbackup.conf.5 
                              pkg-message.in 
  Removed files:
    sysutils/flexbackup  pkg-message 
  Log:
  - Incorporated latest patch set into flexbackup
  - Stylistic changes made to Makefile
  
  PR:             ports/125905
  Submitted by:   Marcus von Appen <mva@sysfault.org> (maintainer)
  Approved by:    beech@ (mentor)
  
  Revision  Changes    Path
  1.25      +11 -18    ports/sysutils/flexbackup/Makefile
  1.1       +395 -0    ports/sysutils/flexbackup/files/patch-flexbackup (new)
  1.1       +11 -0     ports/sysutils/flexbackup/files/patch-flexbackup.1 (new)
  1.2       +135 -4    ports/sysutils/flexbackup/files/patch-flexbackup.conf
  1.1       +77 -0     ports/sysutils/flexbackup/files/patch-flexbackup.conf.5 (new)
  1.1       +29 -0     ports/sysutils/flexbackup/files/pkg-message.in (new)
  1.7       +3 -0      ports/sysutils/flexbackup/pkg-descr
  1.8       +0 -23     ports/sysutils/flexbackup/pkg-message (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"