Bug 125939 - New Port: misc/wanpipe drivers for various sangoma cards
Summary: New Port: misc/wanpipe drivers for various sangoma cards
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-24 22:00 UTC by Josh Paetzel <josh@tcbug.org>
Modified: 2008-08-25 18:00 UTC (History)
0 users

See Also:


Attachments
file.shar (3.82 KB, text/plain)
2008-07-24 22:00 UTC, Josh Paetzel <josh@tcbug.org>
no flags Details
Makefile.diff (780 bytes, patch)
2008-08-19 00:42 UTC, Josh Paetzel <josh@tcbug.org>
no flags Details | Diff
Alex Feldman (alex@sangoma.com).vcf (489 bytes, text/x-vcard)
2008-08-25 15:49 UTC, alex
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Paetzel <josh@tcbug.org> 2008-07-24 22:00:11 UTC
wanpipe drivers for various sangoma telephony and T1 cards
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-17 07:02:05 UTC
State Changed
From-To: open->feedback

Could you please try to build the port in a clean environment (jail 
for example) because there are issues with it trying to determine 
the zaptel source code.
Comment 2 Josh Paetzel <josh@tcbug.org> 2008-08-17 11:47:17 UTC
It builds fine in a jail.  The zaptel port requires the kernel sources to be 
installed.

What issues did you have?

-- 
Thanks,

Josh Paetzel

PGP: 8A48 EF36 5E9F 4EDA 5A8C 11B4 26F9 01F1 27AF AECB
Comment 3 Josh Paetzel <josh@tcbug.org> 2008-08-19 00:42:41 UTC
On Sunday 17 August 2008 05:47:17 am Josh Paetzel wrote:
> It builds fine in a jail.  The zaptel port requires the kernel sources to
> be installed.
>
> What issues did you have?

Per our offlist conversation, the port requires the kernel source tree to 
build and should not be packaged.  Please apply the following patch:

-- --- Makefile.old        2008-08-18 23:25:09.000000000 +0000
+++ Makefile    2008-08-18 23:31:39.000000000 +0000
@@ -35,6 +35,8 @@
 OPTIONS=        TDM_VOICE "Enable TDM Voice support" off           \
                 WAN_PROTOCOL "Enable Wanpipe Protocol support" off

+NO_PACKAGE=    Should be in sync with the kernel to work correctly
+
 .include <bsd.port.pre.mk>

 .if defined(WITH_TDM_VOICE)
@@ -51,6 +53,13 @@
 EXTRA_ARGS+=     WITH_WAN_PROTOCOL
 .endif

+pre-everything::
+       @if [ ! -f /usr/src/sys/Makefile ]; then \
+               ${ECHO_MSG} ">> The wanpipe port needs FreeBSD kernel source 
code to compile."; \
+               ${ECHO_MSG} ">> Please install FreeBSD kernel source code 
in /usr/src/sys."; \
+               ${FALSE}; \
+       fi
+
 do-configure:
        @${SH} ${PKGCONFIG} ${DISTNAME} do-configure ${EXTRA_ARGS}


Attached in case of mail client mangling.


Thanks,

Josh Paetzel

PGP: 8A48 EF36 5E9F 4EDA 5A8C 11B4 26F9 01F1 27AF AECB
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-08-19 01:38:11 UTC
edwin       2008-08-19 00:37:54 UTC

  FreeBSD ports repository

  Modified files:
    misc                 Makefile 
  Added files:
    misc/wanpipe         Makefile distinfo pkg-descr pkg-message 
                         pkg-plist 
    misc/wanpipe/files   patch-configure_port.sh 
  Log:
  New Port: misc/wanpipe drivers for various sangoma cards
  
          This package contains the latest Sangoma drivers that supports following
          Sangoma cards under FreeBSD OS:
          o AFT Series PCI/PCI Express cards
          o S51x PCI cards:
          The current version wanpipe-3.3.1 supports following protocols:
          o Asterisk/Zaptel interface
          o Cisco HDLC, Frame Relay and Point-to-Point
          o PPPoE and PPPoA (for S518 ADSL card)
  
          Release date: Tue Jul 15 14:27:03 UTC 2008
  
  I have added a patch to configure_port.sh to accept a new parameter:
  the WRKSRC and to not enable TDM_VOICE and WANPIPE by default.
  
  Remove the pkg-deinstall script, that was just naughty.
  Added "kldxref" to the pkg-plist (just in case).
  
  Please note that:
  
  - The Makefile contains KMODDIR, but it is not used in the pkg-plist
    and in the softwares Makefiles.
  
  - Please add kldxref to the post-install target.
  
  PR:             ports/125939
  Submitted by:   Josh Paetzel <josh@tcbug.org>
  
  Revision  Changes    Path
  1.886     +1 -0      ports/misc/Makefile
  1.1       +67 -0     ports/misc/wanpipe/Makefile (new)
  1.1       +3 -0      ports/misc/wanpipe/distinfo (new)
  1.1       +53 -0     ports/misc/wanpipe/files/patch-configure_port.sh (new)
  1.1       +10 -0     ports/misc/wanpipe/pkg-descr (new)
  1.1       +4 -0      ports/misc/wanpipe/pkg-message (new)
  1.1       +24 -0     ports/misc/wanpipe/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-19 01:38:14 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 6 Phillip N. 2008-08-19 20:14:50 UTC
Hello,

May i ask why is TDM_VOICE is off by default?

"Voice support" is strong in Sangoma cards, isnit?

thanks
Comment 7 edwin 2008-08-19 20:54:28 UTC
On Tue, Aug 19, 2008 at 07:50:04PM +0000, Phillip N. wrote:
> The following reply was made to PR ports/125939; it has been noted by GNATS.
> 
> From: "Phillip N." <pneumann@gmail.com>
> To: bug-followup@FreeBSD.org, josh@tcbug.org, "Alex Feldman (al.feldman@sangoma.com)" <al.feldman@sangoma.com>
> Cc:  
> Subject: Re: ports/125939: [New Port] misc/wanpipe  drivers for various
> 	sangoma cards
> Date: Tue, 19 Aug 2008 15:14:50 -0400
> 
>  Hello,
>  
>  May i ask why is TDM_VOICE is off by default?
>  
>  "Voice support" is strong in Sangoma cards, isnit?

Note for submitter of PR: If you change this, you should also change
the behaviour of the configure-ports.sh script (maybe this should
be noted in the ports Makefile)

Edwin

-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |              Weblog: http://www.mavetju.org/weblog/
Comment 8 alex 2008-08-25 15:49:38 UTC
Hi Phillip,

I think this is good idea. 
The only reason why I disable TDM_VOICE by default is because it requires
compiling Zaptel/Asterisk ports. But may be we can change it in a future.

Regards,
 
Alex Feldman
Software Project Leader
Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R 9T3
Canada
t. 1 905 474 1990 x 104 | e. alex@sangoma.com

Every AsteriskR Installation Deserves Sangoma Hardware. Because it must
work!

Sangoma support, solutions, drivers and info visit: wiki.sangoma.com

-----Original Message-----
From: Phillip N. [mailto:pneumann@gmail.com] 
Sent: August 19, 2008 3:15 PM
To: bug-followup@FreeBSD.org; josh@tcbug.org; Alex Feldman
(al.feldman@sangoma.com)
Subject: Re: ports/125939: [New Port] misc/wanpipe drivers for
varioussangoma cards

Hello,

May i ask why is TDM_VOICE is off by default?

"Voice support" is strong in Sangoma cards, isnit?

thanks