Bug 126165 - Patches introduced in sysutils/flexbackup 1.2.1_3 cause buffer test to fail
Summary: Patches introduced in sysutils/flexbackup 1.2.1_3 cause buffer test to fail
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-01 19:30 UTC by Anthony Maszeroski
Modified: 2008-09-13 16:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Maszeroski 2008-08-01 19:30:01 UTC
The latest patches to flexbackup caused breakage as the generated buffer test shell script calls a non-existent program named "tempfile" to create a random temporary filename.

Fix: 

Proposed solution (diff of flexbackup)

5288,5289c5288,5289
<     print SCR "tmp_data=\`tempfile\`\n";
<     print SCR "tmp_err=\`tempfile\`\n";
---
>     print SCR "tmp_data=\$(mktemp $cfg::tmpdir/data.XXXXXXXXXX)\n";
>     print SCR "tmp_err=\$(mktemp $cfg::tmpdir/err.XXXXXXXXXX)\n";
How-To-Repeat: Run flexbackup with $buffer = 'buffer' set in flexbackup.conf.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-02 07:22:25 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-02 07:22:26 UTC
Maintainer of sysutils/flexbackup,

Please note that PR ports/126165 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126165

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-02 07:22:29 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2008-09-13 15:09:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 5 Rong-En Fan freebsd_committer freebsd_triage 2008-09-13 15:53:20 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-09-13 15:53:22 UTC
rafan       2008-09-13 14:53:13 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/flexbackup  Makefile 
    sysutils/flexbackup/files patch-flexbackup 
  Log:
  - Since last commit, what using flexbackup with buffer/mbuffer, an error
    is occurred while trying to invoke the non-existent program 'tempfile'.
    This program is not in our base nor in the dependencies installed by
    this port. Fix that by using mktemp instead.
  - Bump PORTREVISION
  
  PR:             ports/126165
  Submitted by:   Anthony Maszeroski <maszeroskia3 at scranton.edu>
  Approved by:    portmgr (erwin), maintainer
  
  Revision  Changes    Path
  1.26      +1 -1      ports/sysutils/flexbackup/Makefile
  1.2       +4 -4      ports/sysutils/flexbackup/files/patch-flexbackup
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"