Bug 126702 - [patch] update multimedia/audacious-plugins to depend on www/neon28
Summary: [patch] update multimedia/audacious-plugins to depend on www/neon28
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Oliver Lehmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-21 07:00 UTC by Josh Paetzel <josh@tcbug.org>
Modified: 2008-08-21 21:10 UTC (History)
0 users

See Also:


Attachments
file.diff (140 bytes, patch)
2008-08-21 07:00 UTC, Josh Paetzel <josh@tcbug.org>
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Paetzel <josh@tcbug.org> 2008-08-21 07:00:10 UTC

multimedia/audacious-plugins has optional neon support.  neon28 is backwards compatable with neon26 but CONFLICTS with it.  More and more ports are pulling in neon28, which will cause this one to bomb.

Fix: Dumb fix simply updates the port to use neon28.....

.if !defined(WITHOUT_NEON)
-LIB_DEPENDS+=  neon.26:${PORTSDIR}/www/neon26
+LIB_DEPENDS+=  neon.28:${PORTSDIR}/www/neon28
 CONFIGURE_ARGS+=--enable-neon
 PLIST_SUB+=    NEONPLUGIN=""
 .else

Otherwise a smarter fix tries to use whatever neon is there, defaulting to neon28



.if !defined(WITHOUT_NEON)
+.if exists(${LOCALBASE}/lib/libneon.so.26)
 LIB_DEPENDS+=  neon.26:${PORTSDIR}/www/neon26
+.else
+LIB_DEPENDS+=  neon.28:${PORTSDIR}/www/neon28
+.endif
 CONFIGURE_ARGS+=--enable-neon
 PLIST_SUB+=    NEONPLUGIN=""
 .else--Af5R4kdRS5NiJe6Wqa0qNTw1IqUcwJMvncrlkxPyMMo5vOeG
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.old        2008-08-20 23:01:33.000000000 -0500
+++ Makefile    2008-08-20 23:01:53.000000000 -0500
@@ -310,7 +310,7 @@
 .endif
How-To-Repeat: 

Install anything that depends on neon28, then install audacious-plugins
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-21 07:00:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->oliver

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-08-21 21:01:40 UTC
oliver      2008-08-21 20:01:31 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/audacious-plugins Makefile 
  Log:
  use neon28 instead of neon26 which is deprecated. neon26 gets only used,
  if neon26 is already installed (to prevent neon conflicting)
  
  PR:             126702
  Submitted by:   "Josh Paetzel" <josh@tcbug.org>
  
  Revision  Changes    Path
  1.58      +5 -1      ports/multimedia/audacious-plugins/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Oliver Lehmann freebsd_committer freebsd_triage 2008-08-21 21:01:59 UTC
State Changed
From-To: open->closed

Committed, Thanks!