Bug 126805 - audio/Teamspeak_server port runs as root by default
Summary: audio/Teamspeak_server port runs as root by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-24 22:20 UTC by richard
Modified: 2008-10-11 08:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description richard 2008-08-24 22:20:07 UTC
By default, the audio/teamspeak_server port runs as root, even though it correctly adds a user/group and sets ownership on the files to the 'teamspeak' user.
The patch below fixes this for me.

Fix: Patch audio/teamspeak_server/files/teamspeak-server.in, the startup script, as follows:

coyote# diff -u teamspeak-server.in.old teamspeak-server.in


. %%RC_SUBR%%

+# Set some defaults
+teamspeak_user=${teamspeak_user:-"teamspeak"}
+
 name=teamspeak
 rcvar=${name}_enable--3cd9RB82FNbAPhA9AkdK6LUn1RzdLtR6PEjrh8AXwnXwnoR4
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- teamspeak-server.in.old     2008-08-24 22:11:05.000000000 +0100
+++ teamspeak-server.in 2008-08-24 22:11:59.000000000 +0100
@@ -15,6 +15,9 @@
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-24 22:43:32 UTC
Maintainer of audio/teamspeak_server,

Please note that PR ports/126805 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126805

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-24 22:43:33 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Stefan Walter freebsd_committer freebsd_triage 2008-10-10 15:14:28 UTC
Hello Ralf,

did you have a look at the patch for audio/teamspeak_server contained in
the PR at [1]? Is it OK to be committed?

Best regards,
Stefan

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126805
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2008-10-10 15:15:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 5 Ralf van der Enden 2008-10-10 20:42:33 UTC
Hi Stefan,

To be honest I must have missed the original PR report. Probably because I
don't run Teamspeak myself anymore.

The patch does look valid though, so it should be okay to commit.

-- 
Regards,
Ralf
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-10-11 08:10:22 UTC
stefan      2008-10-11 07:10:13 UTC

  FreeBSD ports repository

  Modified files:
    audio/teamspeak_server/files teamspeak-server.in 
  Log:
  Patch the startup script so the server process is run as the teamspeak user by
  default, not as root.
  
  PR:             126805
  Submitted by:   Richard Tector <richard@tector.org.uk>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.3       +4 -1      ports/audio/teamspeak_server/files/teamspeak-server.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Stefan Walter freebsd_committer freebsd_triage 2008-10-11 08:11:32 UTC
State Changed
From-To: feedback->closed

Patch committed, thanks!