Bug 126876 - www/xpi-adblock - Makefile.xpi's xpi-gen gets the wrong id sometimes
Summary: www/xpi-adblock - Makefile.xpi's xpi-gen gets the wrong id sometimes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-27 08:30 UTC by Lapo Luchini
Modified: 2010-09-08 01:50 UTC (History)
1 user (show)

See Also:

Attachments
xpi-gen.patch (730 bytes, patch)
2010-06-21 12:12 UTC, Lapo Luchini 		no flags Details | Diff
xpi-gen2.patch (737 bytes, patch)
2010-08-26 14:24 UTC, Lapo Luchini 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lapo Luchini 2008-08-27 08:30:01 UTC 
ports/www/xpi-adblock/Makefile.xpi's xpi-gen target gets the first id 
from install.rdf, which is not always the correct one.

Fix: 

The grep at line 195 can't solve the problem by itself, because the tag 
may be split over multiple line, so it's necessary to use sed or awk to 
choose the correct id.
How-To-Repeat: 
cd /usr/ports/www/xpi-stumbleupon
make xpi-gen

produces:       {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
should produce: {AE93811A-5C9A-4d34-8462-F7B864FC4696}
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-27 08:41:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->infofarmer

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2008-09-07 01:23:02 UTC 
Responsible Changed
From-To: infofarmer->freebsd-ports-bugs

Maintainer was reset.
Comment 3 chinsan freebsd_committer freebsd_triage 2008-09-07 07:41:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->chinsan

I'll take this.
Comment 4 chinsan freebsd_committer freebsd_triage 2009-01-04 18:32:30 UTC 
Responsible Changed
From-To: chinsan->miwi

Pass to new maintainer
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2009-01-04 18:37:16 UTC 
State Changed
From-To: open->closed

fixed in my local tree. a headup for testing will be come to the end of 
next week. Thanks for your report.
Comment 6 Lapo Luchini 2010-06-21 11:32:34 UTC 
I can still reproduce this:

% cd /usr/ports/www/xpi-stumbleupon
% sudo make xpi-gen | fgrep ID
XPI_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
% cd ../xpi-searchstatus
% sudo make xpi-gen | fgrep ID
XPI_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}

The ID that is found seems to be the one referring to Firefox versions
that are compatible with the plugin, not the version of the plugin.
Comment 7 Lapo Luchini 2010-06-21 12:12:45 UTC 
The attached patch fixed the problem for my XPI ports.
Comment 8 Lapo Luchini 2010-08-26 14:24:16 UTC 
Some extensions use a different XML namespace, the attached patch
accounts for that.
Comment 9 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-07 18:35:16 UTC 
State Changed
From-To: closed->open

re-open, was never actually committed
Comment 10 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-07 18:43:56 UTC 
Responsible Changed
From-To: miwi->pgollucci

I will take it
Comment 11 dfilter service freebsd_committer freebsd_triage 2010-09-08 01:44:57 UTC 
pgollucci    2010-09-08 00:44:49 UTC

  FreeBSD ports repository

  Modified files:
    www/xpi-adblock      Makefile.xpi 
  Log:
  - Fix XPI_ID generation when the tag might spam multiple lines [1]
  - Do not install meta data (META-INF) since its not needed
    allow for xpi-post-extract to still work in xpi-* ports [2]
  
  PR:             ports/126876 [1], ports/150327 [2]
  Submitted by:   Lapo Luchini <lapo@lapo.it> [1], [2] tweaked by me
  Approved by:    maintainer timeout (miwi; ~1 yr) [1] [2]
  Tested by:      P6 TB Run, RideCharge TB Run
  
  Revision  Changes    Path
  1.24      +11 -3     ports/www/xpi-adblock/Makefile.xpi
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 12 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-08 01:45:15 UTC 
State Changed
From-To: open->closed

Committed, Thanks!