Bug 127010 - multimedia/mplayer - freetype broken
Summary: multimedia/mplayer - freetype broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: chinsan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-31 19:10 UTC by Barbara
Modified: 2008-09-06 02:40 UTC (History)
0 users

See Also:


Attachments
file.diff (389 bytes, patch)
2008-08-31 19:10 UTC, Barbara
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara 2008-08-31 19:10:01 UTC
I've found that this patch http://www.freebsd.org/cgi/cvsweb.cgi/ports/multimedia/mplayer/files/patch-ad.diff?r1=1.32;r2=1.33;f=h
is breaking the freetype option.
In fact, during configure, the test for iconv fails, voiding the freetype option.

Fix: Include /usr/local/include, where iconv.h is located.
I hope that this doesn't break what the original patch fixes.


Patch attached with submission follows:
How-To-Repeat: Build mplayer with freetype support.
On startup it spits a message about a bitmap font that cannot be loaded (I don't remember the exact message now).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-31 19:10:10 UTC
Maintainer of multimedia/mplayer,

Please note that PR ports/127010 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/127010

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-31 19:10:15 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 chinsan freebsd_committer freebsd_triage 2008-08-31 19:19:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->chinsan

I'll take this.
Comment 4 Thomas E. Zander 2008-09-01 04:03:59 UTC
The fragility of this configure and build process is legendary.

However, I suggest instead of putting "-I/usr/local/include" there,
what about "-I$_prefix/include" ?

Otherwise it will break next week for somebody who defines
${LOCALBASE} to /whatever/somedir

Riggs

-- 
- Now the world has gone to bed  | Now I lay me down to sleep        -
-- Darkness won't engulf my head | Try to count electric sheep      --
--- I can see by infra-red       | Sweet dream wishes you can keep ---
---- How I hate the night        | How I hate the night           ----
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-09-06 02:38:50 UTC
chinsan     2008-09-06 01:38:41 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer/files patch-ad 
  Log:
  - Fx build with freetype
  
  PR:             ports/127010
  Submitted by:   Barbara <barbara.xxx1975 at libero.it>
  Approved by:    Thomas E. Zander (maintainer)
  
  Revision  Changes    Path
  1.34      +1 -1      ports/multimedia/mplayer/files/patch-ad
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 chinsan freebsd_committer freebsd_triage 2008-09-06 02:39:18 UTC
State Changed
From-To: feedback->closed

Committed with some modification, thanks.