Added option to install contrib JARs with the port. Thanks to Mikhail T.
Responsible Changed From-To: freebsd-ports-bugs->miwi miwi@ wants his PRs (via the GNATS Auto Assign Tool)
miwi 2008-09-06 21:11:02 UTC FreeBSD ports repository Modified files: textproc/lucene Makefile Log: - Added option to install contrib JARs with the port. PR: 127147 Submitted by: Gerrit Beine <gerrit.beine@gmx.de> (maintainer) Revision Changes Path 1.4 +32 -2 ports/textproc/lucene/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!
> > Hi all, > > good patch, please approve, Gerrit! > > > > -- Nakata Maho http://accc.riken.jp/maho/ > I did some additions to the patch and submitted it as PR. Gerrit, as submitted, the contributed-JARs are not installed by default. This keeps the port useless for the likes of OOo, which rely on some of these JARs. Can I flip the default to `on'? Thanks! -mi
Hi, Gerrit! You've never replied to this e-mail of mine, and the install of "contrib" JARs remains OFF by default. The PR 127147 was committed without testing and without attribution (which is good, because the WITH_CONTRIB-case was broken), AND the port has since been upgraded again -- to 2.4.0 -- once again missing an opportunity to flip the default without messing with PORTREVISION. Can I commit the attached diff to: 1. Make the WITH_CONTRIB-case work. 2. Make WITH_CONTRIB the default. please? Thanks. Yours, -mi I wrote: = > > Hi all, = > > good patch, please approve, Gerrit! = > > = > > -- Nakata Maho http://accc.riken.jp/maho/ = = > I did some additions to the patch and submitted it as PR. = = Gerrit, as submitted, the contributed-JARs are not installed = by default. This keeps the port useless for the likes of OOo, = which rely on some of these JARs. = = Can I flip the default to `on'? Thanks! = = -mi
Am Freitag, 31. Oktober 2008 13:36:43 schrieb Mikhail Teterin: > Hi, Gerrit! > > You've never replied to this e-mail of mine, and the install of "contrib" > JARs remains OFF by default. The PR 127147 was committed without testing > and without attribution (which is good, because the WITH_CONTRIB-case was > broken), AND the port has since been upgraded again -- to 2.4.0 -- once > again missing an opportunity to flip the default without messing with > PORTREVISION. > > Can I commit the attached diff to: > > 1. Make the WITH_CONTRIB-case work. > 2. Make WITH_CONTRIB the default. > > please? Thanks. Yours, Hi, if it helps you, switch it on. So long... Gerrit