Bug 127467 - bsd.port.mk: fix checking DISTDIR for writeability
Summary: bsd.port.mk: fix checking DISTDIR for writeability
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-18 11:30 UTC by Sergey Skvortsov
Modified: 2014-05-28 16:00 UTC (History)
0 users

See Also:

Attachments
file.diff (674 bytes, patch)
2008-09-18 11:30 UTC, Sergey Skvortsov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Skvortsov freebsd_committer freebsd_triage 2008-09-18 11:30:01 UTC 

Fix: Check real dir, not the parent.
How-To-Repeat: 
# run as unprivileged user in 'wheel' group

sudo chmod g+w /usr/ports/distfiles/vim

cd /usr/ports/editors/vim-lite

make fetch

[skip]

=> vim-7.2.tar.bz2 doesn't seem to exist in /usr/ports/distfiles/vim.
=> /usr/ports/distfiles is not writable by you; cannot fetch.
Comment 1 skv freebsd_committer freebsd_triage 2008-09-18 11:30:34 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Pass.
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-05-28 15:51:33 UTC 
Author: bapt
Date: Wed May 28 14:51:28 2014
New Revision: 355631
URL: http://svnweb.freebsd.org/changeset/ports/355631
QAT: https://qat.redports.org/buildarchive/r355631/

Log:
  fix checking DISTDIR for writeability
  
  PR:		ports/127467
  Submitted by:	Sergey Skvortsov <godegisel@FreeBSD.org>

Modified:
  head/Mk/bsd.port.mk

Modified: head/Mk/bsd.port.mk
==============================================================================
--- head/Mk/bsd.port.mk	Wed May 28 14:46:27 2014	(r355630)
+++ head/Mk/bsd.port.mk	Wed May 28 14:51:28 2014	(r355631)
@@ -3376,8 +3376,8 @@ do-fetch:
 				fi; \
 			fi; \
 			${ECHO_MSG} "=> $$file doesn't seem to exist in ${_DISTDIR}."; \
-			if [ ! -w ${DISTDIR} ]; then \
-			   ${ECHO_MSG} "=> ${DISTDIR} is not writable by you; cannot fetch."; \
+			if [ ! -w ${_DISTDIR} ]; then \
+			   ${ECHO_MSG} "=> ${_DISTDIR} is not writable by you; cannot fetch."; \
 			   exit 1; \
 			fi; \
 			if [ ! -z "$$select" ] ; then \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2014-05-28 15:51:46 UTC 
State Changed
From-To: open->closed

Committed. Thanks!