Bug 128420 - port www/opera operapluginwrapper misparses command line
Summary: port www/opera operapluginwrapper misparses command line
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-27 17:50 UTC by G. Paul Ziemba
Modified: 2008-12-27 10:10 UTC (History)
0 users

See Also:


Attachments
file.diff (295 bytes, patch)
2008-10-27 17:50 UTC, G. Paul Ziemba
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description G. Paul Ziemba 2008-10-27 17:50:01 UTC
% pkg_info|grep opera
opera-9.60.20081004_1 Blazingly fast, full-featured, standards-compliant browser,
opera-linuxplugins-9.60.20081004 Linux plugin support for the native Opera browser

/usr/local/share/opera/bin/operapluginwrapper is called with arguments:
detect -fd 81 -v /usr/local/lib/npapi/linux-flashplugin/libflashplayer.so

It does not handle the case where the plugin filename is in $5, so calls brandelf only as "brandelf -v", which is bogus. Plugin detection fails, since
this plugin is SVR4 but is treated as a FreeBSD-branded file.

Fix: patch ports/www/opera/files/operapluginwrapper:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-27 17:50:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

itetcu@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-27 17:50:14 UTC
Maintainer of www/opera,

Please note that PR ports/128420 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128420

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-27 17:50:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Arjan van Leeuwen 2008-12-10 13:01:42 UTC
This seems to be what happens when debug settings for plugins are enabled.  
The patch is valid.

Arjan

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
Comment 5 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2008-12-15 08:39:49 UTC
State Changed
From-To: feedback->open

maintianer apporved
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-12-27 10:09:15 UTC
itetcu      2008-12-27 10:09:01 UTC

  FreeBSD ports repository

  Modified files:
    www/opera/files      operapluginwrapper 
  Log:
  Try to fix plugin brandelf'ing when pugin debugis enabled.
  
  PR:             ports/128420
  Submitted by:   G. Paul Ziemba
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.4       +2 -0      ports/www/opera/files/operapluginwrapper
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2008-12-27 10:09:16 UTC
State Changed
From-To: open->closed

Committed. Thanks!