Bug 128747 - multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4
Summary: multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-10 09:40 UTC by Joseph S. Atkinson
Modified: 2008-11-15 23:40 UTC (History)
0 users

See Also:


Attachments
file.diff (796 bytes, patch)
2008-11-10 09:40 UTC, Joseph S. Atkinson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph S. Atkinson 2008-11-10 09:40:00 UTC
If a user opts not to build the QT interface, but has opted for the skinnable UI, configure fails.

This informs people selecting these via the OPTIONS framework that QT4 is required for SKINS. If a user defines both anyway via `make config` or in the environment, then WITH_SKINS will be silently ignored in favor of honoring WITHOUT_QT4.

No need to bump PORTREVISION.

Discovered reviewing config.log sent via private email.

Thanks A. B.

Fix: Patch attached with submission follows:
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2008-11-10 11:24:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2008-11-15 23:38:18 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2008-11-15 23:38:23 UTC
miwi        2008-11-15 23:38:13 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/vlc-devel Makefile 
  Log:
  - Fix conflicting WITH_SKINS + WITHOUT_QT4
  
  PR:             128747
  Submitted by:   "Joseph S. Atkinson" <jsa@wickedmachine.net> (maintainer)
  
  Revision  Changes    Path
  1.210     +2 -2      ports/multimedia/vlc-devel/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"