Bug 129656 - Add GNU Fortran 4.3 support to bsd.gcc.mk
Summary: Add GNU Fortran 4.3 support to bsd.gcc.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-15 14:50 UTC by Steven Kreuzer
Modified: 2009-01-05 15:00 UTC (History)
0 users

See Also:


Attachments
file.diff (604 bytes, patch)
2008-12-15 14:50 UTC, Steven Kreuzer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Kreuzer 2008-12-15 14:50:01 UTC
This patch allows a port to be built using gfortran 4.3

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-12-15 14:50:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gerald

bsd.gcc.mk is gerald territory (via the GNATS Auto Assign Tool)
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2009-01-01 11:06:17 UTC
State Changed
From-To: open->feedback

Thanks for the suggestion and the patch, Steven. 


I'm back, pondered about this a bit more, and would like to pursue 
a slightly different approach, cf. the patch below. 

Specifically, I would like to avoid nailing down versions numbers where 
possible, given how this tends to become a big maintenance effort in the 
longer term and how GNU Fortran is maintained upstream (still focusing 
very much on the latest release, seeing a lot of progress, and leveraging 
a good regression testsuite). 

What are your thoughts on this? 

(The effect for what I guess is your usecase should be the same, namely 
the ability to use the later version, right?) 

Gerald 


Update USE_FORTRAN=yes to leverage lang/gcc43 instead of lang/gcc42 
and remove USE_FORTRAN=gfortran42 which is not used by any port anyway. 

Index: bsd.gcc.mk 
=================================================================== 
RCS file: /home/pcvs/ports/Mk/bsd.gcc.mk,v 
retrieving revision 1.20 
diff -u -3 -p -r1.20 bsd.gcc.mk 
--- bsd.gcc.mk	17 Aug 2008 06:57:17 -0000	1.20 
+++ bsd.gcc.mk	1 Jan 2009 11:05:30 -0000 
@@ -67,11 +67,11 @@ GCCVERSION_040300=	999999 999999 4.3 
# 

.if defined (USE_FORTRAN) 
-# gfortran42 from lang/gcc42 is the default for now. 
-. if ${USE_FORTRAN} == yes || ${USE_FORTRAN} == gfortran42 
-BUILD_DEPENDS+=	gfortran42:${PORTSDIR}/lang/gcc42 
-FC:=	gfortran42 
-F77:=	gfortran42 
+# gfortran43 from lang/gcc43 is the default for now. 
+. if ${USE_FORTRAN} == yes 
+BUILD_DEPENDS+=	gfortran43:${PORTSDIR}/lang/gcc43 
+FC:=	gfortran43 
+F77:=	gfortran43 
. endif 

# Intel Fortran compiler from lang/ifc.
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-01-05 14:53:32 UTC
gerald      2009-01-05 14:53:23 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.gcc.mk 
  Log:
  Update USE_FORTRAN=yes to leverage lang/gcc43 instead of lang/gcc42
  and remove USE_FORTRAN=gfortran42 which is not used by any port anyway.
  
  PR:             129656
  
  Revision  Changes    Path
  1.21      +6 -6      ports/Mk/bsd.gcc.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Gerald Pfeifer freebsd_committer freebsd_triage 2009-01-05 14:57:39 UTC
State Changed
From-To: feedback->closed

Steven confirmed that this proposal will be fine from his perspective, 
so this is what we'll do. ;-) 

Thanks for the report, Steven, I believe this triggered a genuine 
improvement for our ports infrastructure!