Bug 129689 - devel/git installs zero-length git-p4import
Summary: devel/git installs zero-length git-p4import
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 19:10 UTC by Evan Powers
Modified: 2008-12-17 15:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Powers 2008-12-16 19:10:00 UTC
See the Makefile for devel/git (v 1.6.0.5):

> # grep -C2 git-p4import.py Makefile
> .ifdef (WITH_P4)
>         @${REINPLACE_CMD} -e'1s|#!/usr/bin/python|#!${PYTHON_CMD}|' \
>                 ${WRKSRC}/contrib/p4import/git-p4import.py > \
>                 ${WRKSRC}/contrib/p4import/git-p4import
> .endif

Note that that's RE*IN*PLACE_CMD, so git-p4import.py gets patched in-place without printing anything to stdout; thus, git-p4import is zero length.

Fix: 

.ifdef (WITH_P4)
        @${CP} ${WRKSRC}/contrib/p4import/git-p4import.py \
                ${WRKSRC}/contrib/p4import/git-p4import
        @${REINPLACE_CMD} -e'1s|#!/usr/bin/python|#!${PYTHON_CMD}|' \
                ${WRKSRC}/contrib/p4import/git-p4import   
.endif
How-To-Repeat: cd /usr/ports/devel/git
make install
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-12-16 19:10:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-12-17 15:42:49 UTC
wxs         2008-12-17 15:42:36 UTC

  FreeBSD ports repository

  Modified files:
    devel/git            Makefile 
  Log:
  - Fix git-p4import so it is not zero size.
  
  PR:             ports/129689
  Submitted by:   Evan Powers <evan.powers+bsdbug@gmail.com>
  
  Revision  Changes    Path
  1.43      +4 -2      ports/devel/git/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Wesley Shields freebsd_committer freebsd_triage 2008-12-17 15:45:26 UTC
State Changed
From-To: open->closed

Committed. Thanks!