Bug 130184 - [patch] mail/exim: fix user/group creation order and errors
Summary: [patch] mail/exim: fix user/group creation order and errors
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-05 12:50 UTC by Artis Caune
Modified: 2009-01-07 07:10 UTC (History)
0 users

See Also:


Attachments
file.diff (793 bytes, patch)
2009-01-05 12:50 UTC, Artis Caune
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Artis Caune 2009-01-05 12:50:01 UTC
- If using EXIM_USER and EXIM_GROUP with packages, install script will fail because it will first try to add user and then group. You can not add user without existing group.

- Install script use ${EXIM_USER}, ${EXIM_GROUP} variables, which are only used in ports, not packages.

Fix: Patch attached with submission follows:
How-To-Repeat: # make EXIM_USER=exim EXIM_GROUP=exim package clean

# pkg_delete exim-4.69_2
# pw group del exim
# pw user del exim

# pkg_add ./exim-4.69_2.tbz
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-01-05 12:50:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->krion

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Kirill Ponomarev freebsd_committer freebsd_triage 2009-01-05 15:44:56 UTC
State Changed
From-To: open->		 feedback

It's a bit arguable, as mailnull user exists by default in /etc/master.passwd 
Are you using non-default master.passwd ?
Comment 3 Artis Caune 2009-01-05 20:40:31 UTC
2009/1/5  <krion@freebsd.org>:
> It's a bit arguable, as mailnull user exists by default in /etc/master.passwd
> Are you using non-default master.passwd ?

I'm using EXIM_USER=exim, EXIM_GROUP=exim (and yes, I have non-default
master.passwd)

In mail/exim/Makefile:pre-install you first add group and then user.
In mail/exim/pkg-install you first add user and then group.

In +INSTALL script there are "user=mailnull" and "group=mail"
variables, but later you use ${EXIM_USER} and ${EXIM_GROUP} which are
not defined and empty.




-- 
regards,
Artis Caune

<----. CCNA | BSDA
<----|====================
<----' didii FreeBSD
Comment 4 Kirill Ponomarew 2009-01-05 21:11:54 UTC
On Jan 5, 2009, at 11:40 PM, Artis Caune wrote:

> 2009/1/5  <krion@freebsd.org>:
>> It's a bit arguable, as mailnull user exists by default in /etc/ 
>> master.passwd
>> Are you using non-default master.passwd ?
>
> I'm using EXIM_USER=exim, EXIM_GROUP=exim (and yes, I have non-default
> master.passwd)
>
> In mail/exim/Makefile:pre-install you first add group and then user.
> In mail/exim/pkg-install you first add user and then group.
>
> In +INSTALL script there are "user=mailnull" and "group=mail"
> variables, but later you use ${EXIM_USER} and ${EXIM_GROUP} which are
> not defined and empty.


OK, gotcha, will fix it tomorrow, thanks a lot.

-Kirill
Comment 5 Kirill Ponomarev freebsd_committer freebsd_triage 2009-01-07 07:08:34 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-01-07 07:08:38 UTC
krion       2009-01-07 07:08:24 UTC

  FreeBSD ports repository

  Modified files:
    mail/exim            pkg-install 
  Log:
  Fix user/group creation order while installing package.
  
  PR:             ports/130184
  Submitted by:   Artis Caune <Artis.Caune@gmail.com>
  
  Revision  Changes    Path
  1.15      +6 -6      ports/mail/exim/pkg-install
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"