Bug 130891 - www/webkit-gtk2: [patch] doesn't compile/install libwebkit-1.0.a
Summary: www/webkit-gtk2: [patch] doesn't compile/install libwebkit-1.0.a
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-22 15:50 UTC by WATANABE Kazuhiro
Modified: 2009-02-01 16:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2009-01-22 15:50:03 UTC
When I build the latest www/webkit-gtk2 port(*) on a 7.1-RELEASE-p2
system to which GNU bash has been installed, libwebkit-1.0.a which is
listed in the pkg-plist is not compiled and installed.

Some people reported the same problem:
http://lists.freebsd.org/pipermail/freebsd-gnome/2009-January/thread.html#21453

If I delete bash from the system, the library is compiled and
installed successfully.

(*) http://live.gnome.org/WebKitGtk

Fix: If bash is installed to the system, this port uses "doltlibtool"
(http://dolt.freedesktop.org/) instead of "libtool".

To solve the problem, I have to edit the Makefile.



The compilation log is here:
http://homepage2.nifty.com/dumb_show/unix/work/webkit-gtk2_with_bash_fix.log.gz


I have some doubts.

(1) When "doltlibtool" is used, a static library is not compiled.
    Is this expected (normal) behavior?

(2) Is this the best workaround?--uHIIkTv0YP7U5Zo5aEDO66WK8JKHn3euDauNmjm4EnI2HXCh
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig	2009-01-10 14:21:47.000000000 +0900
+++ Makefile	2009-01-18 17:36:09.000000000 +0900
@@ -29,7 +29,8 @@
 USE_LDCONFIG=	yes
 USE_AUTOTOOLS=	autoconf:262 automake:110 libtool:15
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
-		LDFLAGS="-L${LOCALBASE}/lib"
+		LDFLAGS="-L${LOCALBASE}/lib" \
+		ac_cv_path_DOLT_BASH=""
 CONFIGURE_ARGS=	--with-webkit-target=x11 \
 		--enable-icon-database \
 		--enable-svg \
How-To-Repeat: (1) With bash

capricorn# pkg_info -W /usr/local/bin/bash
/usr/local/bin/bash was installed by package bash-3.2.48_1
capricorn# make BATCH=yes install deinstall
===>  Vulnerability check disabled, database not found
===>  Extracting for webkit-gtk2-1.0.1_4
...
===>  Configuring for webkit-gtk2-1.0.1_4
...
checking for bash... /usr/local/bin/bash
checking if dolt supports this host... yes, replacing libtool
...
===>  Installing for webkit-gtk2-1.0.1_4
...
===>   Registering installation for webkit-gtk2-1.0.1_4
===>  Deinstalling for www/webkit-gtk2
===>   Deinstalling webkit-gtk2-1.0.1_4
pkg_delete: file '/usr/local/lib/libwebkit-1.0.a' doesn't exist
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
capricorn# 

The complete log is here:
http://homepage2.nifty.com/dumb_show/unix/work/webkit-gtk2_with_bash.log.gz

(2) Without bash

capricorn# pkg_info -W /usr/local/bin/bash
pkg_info: /usr/local/bin/bash: file cannot be found
capricorn# make BATCH=yes install deinstall
===>  Vulnerability check disabled, database not found
===>  Extracting for webkit-gtk2-1.0.1_4
...
===>  Configuring for webkit-gtk2-1.0.1_4
...
checking for bash... no
checking if dolt supports this host... no, falling back to libtool
...
===>  Installing for webkit-gtk2-1.0.1_4
...
===>   Registering installation for webkit-gtk2-1.0.1_4
===>  Deinstalling for www/webkit-gtk2
===>   Deinstalling webkit-gtk2-1.0.1_4
capricorn# 

The complete log is here:
http://homepage2.nifty.com/dumb_show/unix/work/webkit-gtk2_without_bash.log.gz
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-01-22 15:50:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-02-01 16:46:18 UTC
mezz        2009-02-01 16:46:09 UTC

  FreeBSD ports repository

  Modified files:
    www/webkit-gtk2      Makefile 
  Log:
  Somehow, if the configure finds bash then it will using bash's doltlibtool
  then the result a static library will not be compile and install. It ends mess
  up users' plist. Disable to use bash's doltlibtool. Bump the PORTREVISION.
  
  I personal don't understand with bash's doltlibtool issue, so if anyone want
  to dig in it deeper then be my guest.
  
  PR:             ports/130891
  Submitted by:   WATANABE Kazuhiro <CQG00620@nifty.ne.jp>
  
  Revision  Changes    Path
  1.9       +3 -2      ports/www/webkit-gtk2/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jeremy Messenger freebsd_committer freebsd_triage 2009-02-01 16:46:28 UTC
State Changed
From-To: open->closed

Committed, thanks!