Bug 130936 - [PATCH] fix games/tyrquake to work without DGA
Summary: [PATCH] fix games/tyrquake to work without DGA
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alejandro Pulver
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-24 11:10 UTC by rsmith
Modified: 2009-02-19 17:40 UTC (History)
1 user (show)

See Also:

Attachments
tyrquake.patch (5.08 KB, patch)
2009-01-24 11:10 UTC, rsmith 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2009-01-24 11:10:01 UTC 
        On Xorg 7.x with DisableVidModeExtension set, this program dies
        with a bad X request concerning DGA. Enabling the vidmode extension
        messes up the screen.

Fix: I patched the source to remove all traces of DGA. The program works
        fine without it. Other quake ports might benefit from the same
	treatment. 
How-To-Repeat:         Run unmodified tyr-glquake or tyr-quake
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-01-24 11:10:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->alepulver

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alejandro Pulver freebsd_committer freebsd_triage 2009-02-10 22:20:11 UTC 
On Sat, 24 Jan 2009 20:22:55 +0100
Roland Smith <rsmith@xs4all.nl> wrote:

> After installing the modified port, I noticed it was still linked to the
> Xxf86dga library. And I removed the USE_XORG line from the port makefile
> instead of fixing it.
> 
> So I'm including an improved patch. I've used ldd on the binary to try
> and decude the right USE_XORG line. I hope this is complete and not
> overdone. Also added is a patch to the Makefile to remove linking to
> Xxf86dga.
> 

I'm not using DGA, and the mouse did strange things after the patch
(fast rotational movements).

Do you know what's happening here?

Regards,
Ale
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-02-19 17:32:33 UTC 
alepulver    2009-02-19 17:32:23 UTC

  FreeBSD ports repository

  Modified files:
    games/tyrquake       Makefile 
  Added files:
    games/tyrquake/files patch-Makefile 
                         patch-common::gl_vidlinuxglx.c 
                         patch-common::in_x11.c 
                         patch-common::vid_x.c 
  Log:
  - Remove DGA as it causes problems with Xorg 7.x.
  - Bump PORTREVISION.
  - Submitter takes maintainership.
  
  PR:             ports/130936
  Submitted by:   Roland Smith <rsmith@xs4all.nl>
  
  Revision  Changes    Path
  1.12      +3 -2      ports/games/tyrquake/Makefile
  1.3       +11 -0     ports/games/tyrquake/files/patch-Makefile (new)
  1.1       +20 -0     ports/games/tyrquake/files/patch-common::gl_vidlinuxglx.c (new)
  1.1       +116 -0    ports/games/tyrquake/files/patch-common::in_x11.c (new)
  1.1       +19 -0     ports/games/tyrquake/files/patch-common::vid_x.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Alejandro Pulver freebsd_committer freebsd_triage 2009-02-19 17:33:16 UTC 
State Changed
From-To: open->closed

Committed. Thanks!