Bug 131541 - [PATCH] multimedia/vlc: Add xulrunner to USE_GECKO within WITH_VLC_MOZILLA_PLUGIN
Summary: [PATCH] multimedia/vlc: Add xulrunner to USE_GECKO within WITH_VLC_MOZILLA_PL...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-09 21:20 UTC by Naram Qashat
Modified: 2009-02-12 03:50 UTC (History)
1 user (show)

See Also:


Attachments
vlc-0.9.8.a_1,3.patch (555 bytes, patch)
2009-02-09 21:20 UTC, Naram Qashat
no flags Details | Diff
vlc_gecko.diff (407 bytes, patch)
2009-02-10 02:06 UTC, Joseph S Atkinson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2009-02-09 21:20:01 UTC
Add xulrunner to USE_GECKO within WITH_VLC_MOZILLA_PLUGIN

Port maintainer (jsa@wickedmachine.net) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-02-09 21:20:09 UTC
Maintainer of multimedia/vlc,

Please note that PR ports/131541 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131541

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-02-09 21:20:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Joseph S Atkinson 2009-02-10 02:06:15 UTC
I don't want xulrunner to be the default gecko and the order implies 
preference. If you want it to use xulrunner instead of firefox, you need 
to specify `WITH_GECKO=xulrunner` somehow (such as in /etc/make.conf or 
at build time).

NOTE: I cannot test that it will actually build and work with xulrunner 
at this moment, but it's ultimately the end user's mistake to make if 
they choose. It might work one day, but not on the next bump to either 
ports.

If the submitter has no objections, please submit my version instead.

Also, while I am here, slay the dragon known as mozilla since it's old 
and vulnerable and I have no idea why anyone or anything would still 
want to use it (looking at you OpenOffice!). And the same applies to NVU 
(the use of which didn't make a lot of sense here anyway here). These 
save someone the trouble should they (finally) get purged form ports.

aka: jsa@wickedmachine.net
Comment 4 Naram Qashat 2009-02-10 02:20:31 UTC
Joseph S. Atkinson wrote:
> I don't want xulrunner to be the default gecko and the order implies 
> preference. If you want it to use xulrunner instead of firefox, you need 
> to specify `WITH_GECKO=xulrunner` somehow (such as in /etc/make.conf or 
> at build time).
> 
> NOTE: I cannot test that it will actually build and work with xulrunner 
> at this moment, but it's ultimately the end user's mistake to make if 
> they choose. It might work one day, but not on the next bump to either 
> ports.
> 
> If the submitter has no objections, please submit my version instead.

No objection to that.  And I know it builds with xulrunner as I've done it before.

Naram Qashat

> Also, while I am here, slay the dragon known as mozilla since it's old 
> and vulnerable and I have no idea why anyone or anything would still 
> want to use it (looking at you OpenOffice!). And the same applies to NVU 
> (the use of which didn't make a lot of sense here anyway here). These 
> save someone the trouble should they (finally) get purged form ports.
> 
> aka: jsa@wickedmachine.net
>
Comment 5 Beech Rintoul freebsd_committer freebsd_triage 2009-02-11 21:38:24 UTC
State Changed
From-To: feedback->open

Maintainer response 


Comment 6 Beech Rintoul freebsd_committer freebsd_triage 2009-02-11 21:38:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

I'll take it
Comment 7 dfilter service freebsd_committer freebsd_triage 2009-02-12 03:48:58 UTC
beech       2009-02-12 03:48:48 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/vlc       Makefile 
  Log:
  - Add xulrunner to USE_GECKO within WITH_VLC_MOZILLA_PLUGIN
  
  PR:             ports/131541
  Submitted by:   Naram Qashat <cyberbotx@cyberbotx.com>
  Approved by:    Joseph S. Atkinson <jsatkinson@embarqmail.com> (maintainer)
  
  Revision  Changes    Path
  1.182     +3 -2      ports/multimedia/vlc/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Beech Rintoul freebsd_committer freebsd_triage 2009-02-12 03:49:08 UTC
State Changed
From-To: open->closed

Committed, Thanks!