*Update www/davical to version 0.9.6.2 *It will use the recent devel/php-libawl port *It is respecting PORTDOCS The attached patch does the work. Fix: Patch attached with submission follows:
Maintainer of www/davical, Please note that PR ports/131962 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131962 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Looks good but additional patch file 'file/patch-ab' required to include new devel/php-awl port libs
Hi Edwin, I am APPROVING the patch; HOWEVER it requires an additional file 'files/patch-ab' that I have added to the audit trail and I am including in this e-mail. Thanks Maurice Castro On 22/02/2009, at 4:20 PM, Edwin Groothuis wrote: > Maintainer of www/davical, > > Please note that PR ports/131962 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131962 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org
State Changed From-To: feedback->open Approved, but with additional patch (see Audit-Trail).
Responsible Changed From-To: freebsd-ports-bugs->beat I'll take it.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I added some additional changes to the patch: - - Use WWWDIR instead of custom DAVICALDIR variable - - Remove .orig files in post-patch - - Use COPYTREE_SHARE for copying directories and files to preserve file permissions - - Do not install config.php. Instead of this there is an additional step in pkg-message.in. This prevent the deletion of a user modified configuration file when updating the port. You will find the modified patch here: http://people.freebsd.org/~beat/patches/131962-davical.patch Could you please review and approve the patch. Thanks, Beat -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmqsXgACgkQQMW893dCSdu+MwCeMrC2WxLr7YGFwDQIYcOX3ZTv Q/4AnRZdqIFX8pJ/awO+Ir83ttEvaeus =XMh8 -----END PGP SIGNATURE-----
Approved with the following change: The new instruction refers to a file that does not exist; please insert the config directory in the path ie make it read: cp /usr/local/www/davical/config/example-config.php /usr/local/www/ davical/config/config.php This change can be made in line 603 of the patch by inserting 'config/' before the word 'example-config' Maurice Castro On 02/03/2009, at 3:02 AM, Beat Gaetzi wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > I added some additional changes to the patch: > - - Use WWWDIR instead of custom DAVICALDIR variable > - - Remove .orig files in post-patch > - - Use COPYTREE_SHARE for copying directories and files to preserve > file > permissions > - - Do not install config.php. Instead of this there is an > additional step > in pkg-message.in. This prevent the deletion of a user modified > configuration file when updating the port. > > You will find the modified patch here: > http://people.freebsd.org/~beat/patches/131962-davical.patch > > Could you please review and approve the patch. > > Thanks, > Beat > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.10 (FreeBSD) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iEYEARECAAYFAkmqsXgACgkQQMW893dCSdu+MwCeMrC2WxLr7YGFwDQIYcOX3ZTv > Q/4AnRZdqIFX8pJ/awO+Ir83ttEvaeus > =XMh8 > -----END PGP SIGNATURE-----
beat 2009-03-02 22:44:07 UTC FreeBSD ports repository Modified files: www/davical Makefile distinfo pkg-plist www/davical/files pkg-message.in Added files: www/davical/files patch-inc-always.php Log: - Update to 0.9.6.2 [1] - Add devel/php-libawl dependency [1] - Respect NOPORTDOCS [1] - Use COPYTREE_SHARE to copy files [2] - Use WWWDIR instead of custom DAVICALDIR variable [2] - Do not overwrite config file when reinstalling port [2] PR: ports/131962 Submitted by: Cristiano Rolim Pereira <cristianorolim AT hotmail.com> [1], beat [2] Approved by: Maurice Castro <maurice AT castro.aus.net> (maintainer), miwi (mentor) Revision Changes Path 1.2 +25 -24 ports/www/davical/Makefile 1.2 +3 -6 ports/www/davical/distinfo 1.1 +10 -0 ports/www/davical/files/patch-inc-always.php (new) 1.2 +6 -2 ports/www/davical/files/pkg-message.in 1.2 +290 -165 ports/www/davical/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!