Bug 132849 - [PATCH] databases/slony1: rework startup script (daemon, rc.subr)
Summary: [PATCH] databases/slony1: rework startup script (daemon, rc.subr)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jimmy Olgeni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-20 10:40 UTC by Jimmy Olgeni
Modified: 2009-03-22 13:30 UTC (History)
1 user (show)

See Also:


Attachments
slony1-1.2.15.patch (6.54 KB, patch)
2009-03-20 10:40 UTC, Jimmy Olgeni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy Olgeni freebsd_committer freebsd_triage 2009-03-20 10:40:01 UTC
Refactor slon.sh to improve support for rc.subr; also start slon
with the daemon(8) utility to detach it from the terminal.

Limit logging by default to avoid overflowing syslog, and remove
some (disabled) debug code.

Port maintainer (vivek@khera.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-03-20 10:40:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->olgeni

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-03-20 10:40:14 UTC
Maintainer of databases/slony1,

Please note that PR ports/132849 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/132849

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2009-03-20 10:40:17 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 vivek 2009-03-20 13:34:01 UTC
I'll agree to the update.  I don't personally use the rc script to  
start slon; I prefer using the daemontools to manage the processes, so  
I don't have a configuration with which to test this out.

It looks good to me, and given the submitter has commit bits, I'll  
presume it is tested and works.

Thanks for the update!
Comment 5 dfilter service freebsd_committer freebsd_triage 2009-03-22 13:28:34 UTC
olgeni      2009-03-22 13:28:24 UTC

  FreeBSD ports repository

  Modified files:
    databases/slony1/files slon.conf-sample slon.sh.in 
  Log:
  Run slon with daemon(8) to properly detach from the console.
  Set default log levels to 0.
  Remove debug code from startup script.
  
  PR:             ports/132849
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.2       +2 -2      ports/databases/slony1/files/slon.conf-sample
  1.5       +67 -73    ports/databases/slony1/files/slon.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Jimmy Olgeni freebsd_committer freebsd_triage 2009-03-22 13:29:27 UTC
State Changed
From-To: feedback->closed

Patch committed.