Bug 133792 - [PATCH] textproc/docbook-420 fails to install as non-root
Summary: [PATCH] textproc/docbook-420 fails to install as non-root
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Baldwin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-16 21:20 UTC by John Baldwin
Modified: 2009-05-12 15:10 UTC (History)
0 users

See Also:


Attachments
file.diff (439 bytes, patch)
2009-04-16 21:20 UTC, John Baldwin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2009-04-16 21:20:01 UTC
During a 'make install' as non-root, certain make targets are performed after using su to switch to root.  Currently, the docbook-420 port attempts to create a directory in ${PREFIX} before the 'su' occurs which fails.

Fix: Use 'pre-su-install' instead of 'pre-install'.

Patch attached with submission follows:
How-To-Repeat: Run 'make install' as a non-root user (who is in wheel).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-16 22:06:52 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jhb

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-16 22:06:54 UTC
Maintainer of textproc/docbook-420,

Please note that PR ports/133792 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133792

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-16 22:06:56 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Mike Edenfield 2009-04-16 22:14:16 UTC
On 4/16/2009 5:06 PM, Edwin Groothuis wrote:

> Maintainer of textproc/docbook-420,
>
> Please note that PR ports/133792 has just been submitted.

The patch in the PR looks fine, someone should feel free to commit it at 
their earliest convenient.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2009-05-12 15:03:09 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-05-12 15:05:42 UTC
pav         2009-05-12 14:05:25 UTC

  FreeBSD ports repository

  Modified files:
    textproc/docbook-420 Makefile 
  Log:
  - Allow running 'make install' as a non-root user (use 'pre-su-install' instead
    of 'pre-install')
  
  PR:             ports/133792
  Submitted by:   jhb
  Approved by:    Mike Edenfield <kutulu@kutulu.org> (maintainer)
  
  Revision  Changes    Path
  1.4       +1 -1      ports/textproc/docbook-420/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"