Bug 134062 - [PATCH] security/expiretable incorrect pkg-plist macroses / stop daemon on deinstall
Summary: [PATCH] security/expiretable incorrect pkg-plist macroses / stop daemon on de...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-28 12:40 UTC by Alexey Degtyarev
Modified: 2009-05-12 14:40 UTC (History)
0 users

See Also:


Attachments
expiretable.patch (328 bytes, patch)
2009-04-28 12:40 UTC, Alexey Degtyarev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Degtyarev 2009-04-28 12:40:03 UTC
	1. pkg-plist has an invalid @unexec command to stop the expiretable
	daemon: macroses RC_DIR, RC_SUFX are not defined in Makefile, so this
	causes errors at the deinstall routine:
	%RC_DIR%/etc/rc.d/expiretable%RC_SUFX%: not found

	2. A @stopdaemon feature has a more simple syntax.

How-To-Repeat: 	Just install and deinstall port/package.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-28 12:40:11 UTC
Maintainer of security/expiretable,

Please note that PR ports/134062 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134062

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-04-28 12:40:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 cris 2009-04-28 13:43:57 UTC
On 4/28/09 1:40 PM, Edwin Groothuis wrote:
> Maintainer of security/expiretable,
>
> Please note that PR ports/134062 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134062
>


-- 
Cristiano Deana - FreeCRIS
"Ho iniziato a usare FreeBSD perche' m$ usava me. ed e' spiacevole"
Comment 4 Alexey Degtyarev 2009-05-12 12:10:03 UTC
> Synopsis: [PATCH] security/expiretable incorrect pkg-plist macroses / stop daemon on deinstall
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: edwin
> State-Changed-When: Tue Apr 28 11:40:13 UTC 2009
> State-Changed-Why: 
> Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=134062

Hi Cristiano,

can you please be more specific in your reply? Commiters are confused
either you agreed with problem report or not.

Thank you,
-- 
Alexey V. Degtyarev
Comment 5 cris 2009-05-12 13:21:37 UTC
On 4/28/09 1:40 PM, Edwin Groothuis wrote:

> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134062

I agree

-- 
Cristiano Deana - FreeCRIS
"Ho iniziato a usare FreeBSD perche' m$ usava me. ed e' spiacevole"
Comment 6 skv freebsd_committer freebsd_triage 2009-05-12 14:39:44 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2009-05-12 14:39:47 UTC
skv         2009-05-12 13:39:32 UTC

  FreeBSD ports repository

  Modified files:
    security/expiretable pkg-plist 
  Log:
  Use "@stopdaemon" in pkg-plist.
  
  PR:             ports/134062
  Submitted by:   Alexey V.Degtyarev <alexey xx renatasystems.org>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.3       +1 -1      ports/security/expiretable/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"