Postfix 2.6.0 became the stable release as of today. This is a patch against the CVS checkout of 2.5.6 (mail/postfix). There are a few new tools (i.e. binaries) and documentation in 2.6.0, so I hope I captured them all. Although the port builds cleanly, portlint(1) does complain about 3 fatal errors and 2 warnings. However, these are the exact same complaints that are reported when running portlint(1) on the existing (already committed to the tree) mail/postfix, so I have not addressed them. Please let me know of any mistakes -- happy to refine and re-submit the patch. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->beech beech@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of mail/postfix, Please note that PR ports/134497 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134497 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Something seems wrong here.. There's no reason for the config files master.cf and main.cf to move from etc/ to libexec/. What's causing that?
Hi Vivek, The config files (master.cf and main.cf) do not move from etc/ to libexec/; they remain in the former but are added to the latter. I agree this seems odd, but it reflects changes in the underlying source. The stock configuration files in $daemon_directory are used by the new multi-instance support introduced in 2.6.0. Postfix 2.5.7: % grep main.cf postfix-2.5.7/conf/postfix-files $config_directory/main.cf.default:f:root:-:644 $config_directory/main.cf:f:root:-:644:p % grep master.cf postfix-2.5.7/conf/postfix-files $config_directory/master.cf:f:root:-:644:p Postfix 2.6.0 (notice addition of the $daemon_directory): % grep main.cf postfix-2.6.0/conf/postfix-files $daemon_directory/main.cf:f:root:-:644 $config_directory/main.cf.default:f:root:-:644:1 $config_directory/main.cf:f:root:-:644:p % grep master.cf postfix-2.6.0/conf/postfix-files $daemon_directory/master.cf:f:root:-:644 $config_directory/master.cf:f:root:-:644:p % grep \$daemon postfix-2.6.0/src/postmulti/postmulti.c /* $daemon_directory/main.cf, stock configuration file /* $daemon_directory/master.cf, stock configuration file /* $daemon_directory/postmulti-script, life-cycle helper program -- Sahil Tandon <sahil@tandon.net>
ok. that makes sense. are the main.cf and master.cf files in libexec expected to be edited? if so, they should be installed like the others as ".default" so they don't get removed when the package is deleted. it is bad to delete config files that are expected to be edited. also, are you interested in taking over this port maintainership? i'm really short on time and I have about a dozen other ports I maintain.
From my (very cursory) reading of the code, the stock main and master.cf files in libexec/ are used only during the creation of a new instance, and are not for user editing like the configuration files in $config_directory. I would be glad to take over maintainership if that suits you. Let me know!
I approve this patch. I also approve Sahil taking over as the maintainer, which we have discussed privately.
State Changed From-To: feedback->open Maintainer approved
Responsible Changed From-To: beech->pav Steal
State Changed From-To: open->closed Committed, thanks!
pav 2009-05-18 14:36:34 UTC FreeBSD ports repository Modified files: mail/postfix Makefile distinfo pkg-install pkg-plist Removed files: mail/postfix/files patch-conf__postfix-files Log: - Update to 2.6.0 - Transfer maintainership to the submitter PR: ports/134497 Submitted by: Sahil Tandon <sahil@tandon.net> Approved by: Vick Khera <vivek@khera.org> (old maintainer) Revision Changes Path 1.144 +10 -10 ports/mail/postfix/Makefile 1.99 +3 -6 ports/mail/postfix/distinfo 1.2 +0 -11 ports/mail/postfix/files/patch-conf__postfix-files (dead) 1.27 +2 -2 ports/mail/postfix/pkg-install 1.27 +12 -3 ports/mail/postfix/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"