Bug 134889 - [patch] www/p5-libapreq2: pass down MAKE=${GMAKE} to let MakeMAker generate proper makefiles
Summary: [patch] www/p5-libapreq2: pass down MAKE=${GMAKE} to let MakeMAker generate p...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-24 06:20 UTC by Eygene Ryabinkin
Modified: 2009-07-10 17:10 UTC (History)
0 users

See Also:


Attachments
2.12-pass-down-MAKE-equal-to-gmake.diff (1.60 KB, patch)
2009-05-24 06:20 UTC, Eygene Ryabinkin
no flags Details | Diff
file.diff (607 bytes, patch)
2009-05-24 06:20 UTC, Eygene Ryabinkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene Ryabinkin 2009-05-24 06:20:01 UTC
Port build for 2.12 chokes at the time of processing of Makefile
generated by Makefile.PL:
-----
gmake[2]: Entering directory
`/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue/perl'
cp lib/Apache2/Cookie.pm blib/lib/Apache2/Cookie.pm
cp lib/Apache2/Upload.pm blib/lib/Apache2/Upload.pm
cp lib/Apache2/Request.pm blib/lib/Apache2/Request.pm
cp lib/APR/DummyVersions.pm blib/lib/APR/DummyVersions.pm
make: don't know how to make w. Stop
gmake[2]: *** [subdirs] Error 2
gmake[2]: Leaving directory
`/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue/perl'
gmake[1]: *** [perl_glue] Error 2
gmake[1]: Leaving directory
`/usr/ports/www/p5-libapreq2/work/libapreq2-2.12/glue'
gmake: *** [all-recursive] Error 1
*** Error code 1

Stop in /usr/ports/www/p5-libapreq2.
-----

The problem is that MakeMaker defines
-----
MAKE=make
----
and that's wrong -- we should invoke gmake for the subdirectories.

Fix: The following patch adds make variable MAKE that is set to ${GMAKE}.
This fixes the issue for me.  Tinderbox builds on 6.x, 7.x and 8.x
are also fine for the patched port.
And this patch fixes pkg-plist.
From 7abb5b715c2173fb133d0ea264dc2439fe3746e9 Mon Sep 17 00:00:00 2001
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Date: Sun, 24 May 2009 09:03:26 +0400
Subject: [PATCH] www/p5-libapreq: fix pkg-plist

Signed-off-by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
---
 www/libapreq2/pkg-plist |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
How-To-Repeat: 
Just try to build www/p2-libapreq2.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-05-24 06:20:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->skv

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2009-05-26 00:18:29 UTC
Responsible Changed
From-To: skv->pgollucci

I broke it I'll fix it
Comment 3 dfilter service freebsd_committer freebsd_triage 2009-05-26 00:24:00 UTC
pgollucci    2009-05-25 23:23:50 UTC

  FreeBSD ports repository

  Modified files:
    www/libapreq2        pkg-plist 
    www/p5-libapreq2     Makefile 
  Log:
  Without this, Perl's MakeMaker generates Makefiles with 'MAKE=make' and
  this is bad for subdirectory targets where $(MAKE) is used: pmake is
  invoked instead of GNU Make, so make process chokes at this point,
  
  NO PORTREVISION bump since the packages were bumped before and never built after
  the 2.12 update.
  
  PR:             ports/134889
  Submitted by:   Eygene Ryabinkin <rea-fbsd@codelabs.ru>
  Pointyhat to:   myself
  
  Revision  Changes    Path
  1.12      +1 -0      ports/www/libapreq2/pkg-plist
  1.16      +1 -0      ports/www/p5-libapreq2/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2009-05-26 00:24:06 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 5 Vivek Khera 2009-07-10 16:42:52 UTC
This needs to be patched in www/libapreq2 as well (the base port).  If  
you have WITH_MODPERL2 defined in the make.conf file, this bug gets  
triggered when installing the base port.

THanks!