r193187 removes vfs_bio_set_validclean in favour of vfs_bio_set_valid. The two appear to be functionally the same. Fix: See attached for the patches that use vfs_bio_set_validclean as an alias for vfs_bio_set_valid if vfs_bio_set_validclean is not defined. (Compile tested only) Patch attached with submission follows: How-To-Repeat: make -C/usr/ports/sysutils/fusefs-kmod all
Maintainer of sysutils/fusefs-kmod, Please note that PR ports/135285 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/135285 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->wxs I'll take it.
This patch causes the port to fail on -current and 6-STABLE with the following (sorry for the line wrap): cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I../include -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c fuse_io.c cc1: warnings being treated as errors fuse_io.c: In function 'fuse_write_biobackend': fuse_io.c:756: warning: implicit declaration of function 'vfs_bio_set_valid' fuse_io.c:756: warning: nested extern declaration of 'vfs_bio_set_valid' *** Error code 1 Stop in /work/a/ports/sysutils/fusefs-kmod/work/fuse4bsd-498acaef33b0/fuse_module. *** Error code 1 Can you please look into solving this issue. I'll be happy to test any patches you want. Thanks! -- WXS
On Tue, Jun 16, 2009 at 11:16:40AM +0200, David Naylor wrote: > On Monday 15 June 2009 16:19:04 Wesley Shields wrote: > > This patch causes the port to fail on -current and 6-STABLE with the > > following (sorry for the line wrap): > > > > cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE > > -nostdinc -I../include -I. -I@ -I@/contrib/altq -finline-limit=8000 > > --param inline-unit-growth=100 --param large-function-growth=1000 > > -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 > > -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding > > -fstack-protector -std=iso9899:1999 -fstack-protector -Wall > > -Wredundant-decls -Wnested-externs -Wstrict-prototypes > > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > > -Wno-pointer-sign -fformat-extensions -c fuse_io.c > > cc1: warnings being treated as errors > > fuse_io.c: In function 'fuse_write_biobackend': > > fuse_io.c:756: warning: implicit declaration of function > > 'vfs_bio_set_valid' > > fuse_io.c:756: warning: nested extern declaration of 'vfs_bio_set_valid' > > *** Error code 1 > > > > Stop in > > /work/a/ports/sysutils/fusefs-kmod/work/fuse4bsd-498acaef33b0/fuse_module. > > *** Error code 1 > > > > Can you please look into solving this issue. I'll be happy to test any > > patches you want. Thanks! > > Good news: used wrong approach to fix it, should be fixed in attached patches. > > Bad news: with the very recent changes in VFS trying to use sshfs core dumps > my system so the code will compile but probably kill the computer. > > Unfortunately this fix works with a kernel a few weeks old... But now only > allows the code to compile. Thank you for following up but as you said if the code breaks at runtime that's just as bad as it not compiling. I will go ahead and mark this port broken on current and hopefully you can come up with a proper fix. Thanks! -- WXS
wxs 2009-06-16 14:55:36 UTC FreeBSD ports repository Modified files: sysutils/fusefs-kmod Makefile Log: - Mark as broken on 8.x. There are two PRs about this. The first (ports/135285) has a patch but that causes coredumps. The second (ports/135621) has not been tested yet but the port should still be marked as broken until a proper fix is put in place. PR: ports/135285 Submitted by: David Naylor <naylor.b.david@gmail.com> Approved by: maintainer timeout Revision Changes Path 1.28 +4 -0 ports/sysutils/fusefs-kmod/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Same as previous patch, just not mangled by kmail. http://am-productions.biz/docs/fusefs-kmod-buildfix.patch -- Anish Mistry amistry@am-productions.biz AM Productions http://am-productions.biz/
On Thursday 09 July 2009 16:47:52 Anish Mistry wrote: > The attached patch fixes build and: > ports/136211 > ports/135621 It works fine here for me. Stress tested with sshfs. There is no need for your patch to remove the three *.orig files (since they do not exist). Thanks
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!