Bug 136459 - [patch] mail/postfix: fix build on 8.x
Summary: [patch] mail/postfix: fix build on 8.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Giorgos Keramidas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 13:10 UTC by Eygene Ryabinkin
Modified: 2009-07-09 14:20 UTC (History)
0 users

See Also:


Attachments
2.6.2-fix-8.x-build.diff (2.54 KB, patch)
2009-07-08 13:10 UTC, Eygene Ryabinkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene Ryabinkin 2009-07-08 13:10:03 UTC
Since the addition of the closefrom(2) system call,
  http://lists.freebsd.org/pipermail/svn-src-all/2009-June/010768.html
Postfix fails to build, because it is unaware of this change and tries
to push its own version of closefrom(2).

Fix: The following patch will fix the things.  We can do it via Makefile
and CFLAGS, but I expect that this patch will go upstream, so it is
better to patch the things closer to the original.

Since closefrom(2) promised to be MFC'ed, I'll try to keep an eye
on this and will submit another variant of patch (if it will be
needed).

Patched port passes my Tinderbox builds for 6.x, 7.x and 8.x.  Two
instances of updated port are running fine on my 8.x machines.
How-To-Repeat: 
Try to build Postfix port (2.6.2_1,1) on 8-CURRENT after 15th of June
2009.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-08 13:10:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-08 13:10:16 UTC
Maintainer of mail/postfix,

Please note that PR ports/136459 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136459

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-08 13:10:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Sahil Tandon 2009-07-09 00:35:16 UTC
Ah, good old closefrom(2) back to haunt us. :-)  This patch is approved as it
looks rather straightforward.  Unfortunately I am unable to test on a 8.x
tindy. :(

-- 
Sahil Tandon <sahil@tandon.net>
Comment 5 Giorgos Keramidas freebsd_committer freebsd_triage 2009-07-09 07:51:52 UTC
On Wed,  8 Jul 2009 16:08:19 +0400 (MSD), Eygene Ryabinkin <rea-fbsd@codelabs.ru> wrote:
>>Number:         136459
>>Category:       ports
>>Synopsis:       [patch] mail/postfix: fix build on 8.x

>>Description:
>
> Since the addition of the closefrom(2) system call,
>   http://lists.freebsd.org/pipermail/svn-src-all/2009-June/010768.html
> Postfix fails to build, because it is unaware of this change and tries
> to push its own version of closefrom(2).

Sahil Tandon <sahil@tandon.net> wrote:
> Ah, good old closefrom(2) back to haunt us. :-) This patch is approved
> as it looks rather straightforward.  Unfortunately I am unable to test
> on a 8.x tindy. :(

I independently came up with the *same* patch and tested it on 8.0-BETA1
this morning, so I can commit the patch to ports/.  The patched version
of Postfix seems to work fine so far.  I have been using it on 8.0, to
test my TLS setup for $work email alll morning, and didn't notice any
odd problems.

Should I go ahead and commit Eygene's patch?
Comment 6 Eygene Ryabinkin 2009-07-09 08:21:17 UTC
Giorgos, good day.

Thu, Jul 09, 2009 at 09:51:52AM +0300, Giorgos Keramidas wrote:
> Sahil Tandon <sahil@tandon.net> wrote:
> > Ah, good old closefrom(2) back to haunt us. :-) This patch is approved
> > as it looks rather straightforward.  Unfortunately I am unable to test
> > on a 8.x tindy. :(
> 
> I independently came up with the *same* patch and tested it on 8.0-BETA1
> this morning, so I can commit the patch to ports/.  The patched version
> of Postfix seems to work fine so far.  I have been using it on 8.0, to
> test my TLS setup for $work email alll morning, and didn't notice any
> odd problems.

My two machines (Postfix, TLS, but no incoming stuff, only outgoing
ones) still work fine too since yesterday.

Thank you both for handling this issue!
-- 
Eygene
 _                ___       _.--.   #
 \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
 /  ' `         ,       __.--'      #  to read the on-line manual
 )/' _/     \   `-_,   /            #  while single-stepping the kernel.
 `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
     _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
    {_.-``-'         {_/            #
Comment 7 Sahil Tandon 2009-07-09 12:15:31 UTC
On Jul 9, 2009, at 2:51 AM, Giorgos Keramidas <keramida@freebsd.org>  
wrote:

> On Wed,  8 Jul 2009 16:08:19 +0400 (MSD), Eygene Ryabinkin <rea-fbsd@codelabs.ru 
> > wrote:
>>> Number:         136459
>>> Category:       ports
>>> Synopsis:       [patch] mail/postfix: fix build on 8.x
>
>>> Description:
>>
>> Since the addition of the closefrom(2) system call,
>>  http://lists.freebsd.org/pipermail/svn-src-all/2009-June/010768.html
>> Postfix fails to build, because it is unaware of this change and  
>> tries
>> to push its own version of closefrom(2).
>
> Sahil Tandon <sahil@tandon.net> wrote:
>> Ah, good old closefrom(2) back to haunt us. :-) This patch is  
>> approved
>> as it looks rather straightforward.  Unfortunately I am unable to  
>> test
>> on a 8.x tindy. :(
>
> I independently came up with the *same* patch and tested it on 8.0- 
> BETA1
> this morning, so I can commit the patch to ports/.  The patched  
> version
> of Postfix seems to work fine so far.  I have been using it on 8.0, to
> test my TLS setup for $work email alll morning, and didn't notice any
> odd problems.
>
> Should I go ahead and commit Eygene's patch?

Hello gents.  Yes please commit away.  A few years back we had a  
similar closefrom problem on Solaris and it was fixed quite like  
this. :). Thanks for the help!  I suspect Wietse will make the change  
upstream so we will eventually be rolling this back.
Comment 8 dfilter service freebsd_committer freebsd_triage 2009-07-09 14:15:17 UTC
keramida    2009-07-09 13:15:07 UTC

  FreeBSD ports repository (doc committer)

  Added files:
    mail/postfix/files   patch-src::util::sys_defs.h 
  Log:
  Patch the src/util/sys_defs.h file of Postfix to fix the build on
  FreeBSD-8.0 after the new closefrom() system call was added.
  
  PR:             ports/136459
  Submitted by:   Eygene Ryabinkin
  Approved by:    erwin (portmgr), Sahil Tandon (maintainer)
  
  Revision  Changes    Path
  1.4       +18 -0     ports/mail/postfix/files/patch-src::util::sys_defs.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Giorgos Keramidas freebsd_committer freebsd_triage 2009-07-09 14:15:23 UTC
State Changed
From-To: feedback->closed

I've committed this in Makefile rev 1.4, thank you :) 


Comment 10 Giorgos Keramidas freebsd_committer freebsd_triage 2009-07-09 14:15:23 UTC
Responsible Changed
From-To: miwi->keramida

Take.