Bug 136611 - security/swatch: leaves zombies behind
Summary: security/swatch: leaves zombies behind
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-09 11:40 UTC by Thomas Quinot
Modified: 2010-05-19 20:00 UTC (History)
0 users

See Also:


Attachments
file.diff (281 bytes, patch)
2009-07-09 11:40 UTC, Thomas Quinot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Quinot 2009-07-09 11:40:01 UTC
	When a Swatch rule has an "exec" action, child processes are not
	correctly cleaned up.

Fix: The following quick and dirty patches adds a missing (blocking) waitpid
	call, it's fine if the action executes in bounded time, if not it needs
	to be refined.
How-To-Repeat: 	Define an "exec" action and watch for zombie processes
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-09 11:40:10 UTC
Maintainer of security/swatch,

Please note that PR ports/136611 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136611

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-09 11:40:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2010-01-18 07:26:47 UTC
ping....
Comment 4 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-05-09 02:43:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

I'll take it.
Comment 5 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-05-09 02:49:15 UTC
Maintainer, do you approve this patch?
Comment 6 joseph 2010-05-10 17:48:53 UTC
Sure, go for it.

On Sat, May 8, 2010 at 7:49 PM, Sylvio Cesar Teixeira
<sylvio@freebsd.org> wrote:
> Maintainer, do you approve this patch?



-- 
Joseph Scott
joseph@josephscott.org
http://josephscott.org/
Comment 7 dfilter service freebsd_committer freebsd_triage 2010-05-19 19:52:24 UTC
sylvio      2010-05-19 18:52:10 UTC

  FreeBSD ports repository

  Added files:
    security/swatch/files patch-lib-Swatch_Actions.pm 
  Log:
  - Fix when a Swatch rule has an "exec" action, child processes are not
  correctly cleaned up.
  
  PR:             ports/136611
  Submitted by:   Thomas Quinot <thomas@cuivre.fr.eu.org>
  Approved by:    Joseph Scott <joseph@josephscott.org> (maintainer)
  
  Revision  Changes    Path
  1.1       +11 -0     ports/security/swatch/files/patch-lib-Swatch_Actions.pm (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-05-19 19:53:07 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!