Bug 136657 - [PATCH] ports-mgmt/portlint: Fix string comparison with undef
Summary: [PATCH] ports-mgmt/portlint: Fix string comparison with undef
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-11 09:50 UTC by Greg Lewis
Modified: 2009-07-18 22:50 UTC (History)
1 user (show)

See Also:


Attachments
portlint-2.12.0.patch (706 bytes, patch)
2009-07-11 09:50 UTC, Greg Lewis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Lewis freebsd_committer freebsd_triage 2009-07-11 09:50:00 UTC
portlint currently does potential comparisons against undef when checking
for manual pages in the packing list.  E.g., when I run it against the
current version of the lang/mono port I see errors like this:

Use of uninitialized value in string eq at /usr/local/bin/portlint line 914, <IN> line 865.
FATAL: /usr/ports/lang/mono/pkg-plist: [865]: unpacked man file csharp.1 listed. must be gzipped.
Use of uninitialized value in string ne at /usr/local/bin/portlint line 931, <IN> line 865.

Since perl considers a blank string "false", changing the conditionals from
an explicit string (in)equality check to a true/false on the value itself
fixes it for me.

I'll submit a separate patch to fix the problems with mono.

Port maintainer (marcus@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-11 09:50:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-07-18 22:39:21 UTC
marcus      2009-07-18 21:39:07 UTC

  FreeBSD ports repository

  Modified files:
    ports-mgmt/portlint  Makefile 
    ports-mgmt/portlint/src portlint.pl 
  Log:
  Update to 2.12.1.
  
  * Do not compare a string with undef. [1]
  * Remove the CONFIGURE_ARGS check for --prefix.  This is not part of
    _LATE_CONFIGURE_ARGS, and thus will be set of all ports. [2]
  
  PR:             136657 [1]
                  136691 [2]
  Submitted by:   glewis [1]
  
  Revision  Changes    Path
  1.134     +1 -1      ports/ports-mgmt/portlint/Makefile
  1.111     +7 -7      ports/ports-mgmt/portlint/src/portlint.pl
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2009-07-18 22:39:53 UTC
State Changed
From-To: open->closed

Committed, thanks!