Bug 136868 - Update port: devel/ocaml-findlib honor NO_TK option of lang/ocaml
Summary: Update port: devel/ocaml-findlib honor NO_TK option of lang/ocaml
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-17 15:00 UTC by Rick van der Zwet
Modified: 2009-07-24 12:20 UTC (History)
0 users

See Also:

Attachments
file.diff (1.37 KB, patch)
2009-07-17 15:00 UTC, Rick van der Zwet 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rick van der Zwet 2009-07-17 15:00:12 UTC 
The port does not honor, when lang/ocaml is build WITHOUT_TK option. 

This is kind of painful on package building, as it fails to find some files and failing of that cause.

Fix: Attached patch checks if requested directory is installed and disables plist flags if needs.


Patch attached with submission follows:
How-To-Repeat: # cd /usr/ports/devel/ocaml-findlib
# make install
# make deinstall
===>  Deinstalling for devel/ocaml-findlib
===>   Deinstalling ocaml-findlib-1.2.4
pkg_delete: file '/usr/local/lib/ocaml/site-lib/labltk/META' doesn't exist
pkg_delete: file '/usr/local/lib/ocaml/site-lib/labltk' doesn't exist
pkg_delete: unable to completely remove directory '/usr/local/lib/ocaml/site-lib/labltk'
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-17 15:00:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->johans

johans@stack.nl => johans@ (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-17 15:00:25 UTC 
Maintainer of devel/ocaml-findlib,

Please note that PR ports/136868 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136868

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-17 15:00:26 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-07-23 20:40:44 UTC 
johans      2009-07-23 19:40:30 UTC

  FreeBSD ports repository

  Modified files:
    devel/ocaml-findlib  Makefile pkg-plist 
  Log:
  Fix package list when ocaml has been installed without TK
  
  PR:             ports/136868
  Submitted by:   Rick van der Zwet
  
  Revision  Changes    Path
  1.22      +10 -0     ports/devel/ocaml-findlib/Makefile
  1.6       +2 -2      ports/devel/ocaml-findlib/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Johan van Selst freebsd_committer freebsd_triage 2009-07-24 12:19:52 UTC 
State Changed
From-To: feedback->closed

Committed with minor modifications. Thanks.